Repository navigation
Put the reply bar's expand button inside the field on iOS - #97
Merged
Merged
Conversation
On iOS the reply field is a Liquid Glass plate, and a field's own controls belong inside it at the trailing edge, so the expand button now sits there and stays at the bottom as the draft grows. It's beside the field's press target rather than in it, so pressing it doesn't fold the earlier commits away as a tap on the field does. Android keeps it ahead of the field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS the reply field on a commit page is a Liquid Glass plate, and the expand button sat outside it on the left. iOS puts a field's own controls inside the field at its trailing edge, so the button now lives there. It stays at the bottom of the plate as the draft grows to several lines.
Android is unchanged: the button still leads the bar. Its after shots are pixel-identical to the before shots apart from the system gesture bar.
Things to look at:
reply-fieldto a newreply-platerow that holds the field and the button.reply-fieldkeeps the@pressUpthat tells the page you're replying, and the button sits beside it rather than inside it, so pressing expand doesn't also fold away the earlier commits.Platform::isIos()in the view, since it's a different tree on each platform rather than a different class.reply-plate, and a new test checks where the button sits on each platform.Screenshots
A long draft on iOS, with the button staying at the bottom of the field:
🤖 Generated with Claude Code