Repository navigation
Update mobile-browser to 1.2 so the sign-in tab can't strand the app - #59
Merged
Merged
Conversation
1.2.0 opens Browser::auth()'s Custom Tab in its own task on Android. Before, a sign-in tab left open when the app was updated, force-stopped or killed in the background became what the launcher reopened, and the app never started (seen on the Moto g24). It also has the iOS fix for opening custom schemes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires nativephp/mobile-browser ^1.2 and updates only that package in the lock (1.1.0 to 1.2.0).
1.2.0 brings NativePHP/mobile-browser#3. On Android,
Browser::auth()now opens the dev-null.sh sign-in tab in a task of its own. Before, a sign-in tab left open when the app was updated, force-stopped or killed in the background became the thing the launcher reopened, so the app never started. That's what kept happening on the Moto g24. It also includes NativePHP/mobile-browser#2, which makes iOS open custom schemes instead of always reporting failure.The plugin adds an activity and an init function, so Android needs
php artisan native:install android(or a fresh build) to pick them up. While a sign-in is open, Recents shows the app and the sign-in page as two cards, and coming back to the app brings the tab back to the front.The Onboarding, This device, profile, commit detail and issue command tests pass (128). The same plugin code ran on the Moto during review of mobile-browser#3: a full sign-in, plus update, force-stop and background kill with the tab open.
🤖 Generated with Claude Code