Repository navigation
Conversation
Silent NSIS install can take minutes on Windows; relaunch during install leaves app stuck. Default stays true. Fixes NativePHP#90
zamuwelle
force-pushed
the
feat/auto-install-on-quit-config
branch
from
October 29, 2026 04:50
5e19df2 to
ffff37a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90
electron-updaterinstalls downloaded updates automatically when the app quits. On Windows the NSIS installer runs silently and can take minutes, so relaunching the app during that window leaves it stuck on the loading screen.This makes the behavior configurable with
NATIVEPHP_AUTO_INSTALL_ON_APP_QUIT(defaulttrue, so existing apps keep the current behavior). Set it tofalseto control installation and callUpdater::quitAndInstall()when ready. This addresses the feedback on #92 that disabling it unconditionally would be a breaking change. Existing apps need to republishconfig/nativephp.php(or add the key) to use the setting.Tests
npx tsc --noEmit -p electron-plugin/tsconfig.json: passedvendor/bin/pint --test: passed