Repository navigation
Conversation
.env value stayed in PHP config; electron-builder saw updater as disabled and skipped upload. Fixes NativePHP#102
zamuwelle
force-pushed
the
fix/publish-updater-env
branch
from
October 29, 2026 04:57
1cbc62b to
b16e9c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102
native:publishdid not upload artifacts whenNATIVEPHP_UPDATER_ENABLED=truewas only set in.env. The value reached the PHP config but was never passed to the Node process, soelectron-builder.mjsalways saw the updater as disabled and skipped thepublishconfig. RunningNATIVEPHP_UPDATER_ENABLED=true php artisan native:publishworked because the variable was inherited from the shell.This passes the resolved config value through to electron-builder.
Tests
vendor/bin/pest tests/Build/BuildCommandEnvironmentVariablesTest.php: 5 passedvendor/bin/pint --test: passed