Repository navigation
Add a Clang 24 CI job to protect the modular build - #2308
Merged
Merged
Conversation
Add a "CPU (clang trunk, Debug, modules)" row to the CPU matrix that builds Clang from llvm-project at a pinned commit and uses it for the modular build. The pin is the merge of llvm/llvm-project#224528 (f970f59a9d4e), which fixes the nondeterministic Clang 23.1.0 ICE in ImplicitConceptSpecializationDecl deserialization (llvm/llvm-project#191361) that the modular build hits. The job reuses the existing llvm22 rapidsai devcontainer image. It builds a stripped Release toolchain limited to what the modular build needs (clang, its resource headers, clang-scan-deps, and libc++/libc++abi/libunwind) and caches it keyed on the commit and image tag, saving the cache explicitly so a failing stdexec build doesn't discard it. Only bumping llvm_sha or the image tag triggers a rebuild. Rows without llvm_sha are unaffected: the new steps are skipped and the configure line falls back to the image's libc++.modules.json as before.
The Clang 22 modules row was allowed to fail because every released 22.1.x ICEs in the modular build. The from-source row now covers the modular build with a compiler that doesn't, so the Clang 22 row adds nothing. Update MAINTAINERS.md to say which compiler the modular build is tested with.
ericniebler
force-pushed
the
ci-clang-trunk-modules
branch
from
October 8, 2026 00:10
5f49f1b to
25d91ff
Compare
ericniebler
approved these changes
Oct 8, 2026
Collaborator
|
/ok to test 25d91ff |
Collaborator
|
Thanks @ispeters ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes replaces the existing modular Clang 22 build with a Clang 24 build that builds Clang from source before building stdexec. It pins Clang 24 to the commit that resolved the ICE that plagued Clang 22 and 23.
The Clang build is cached separately from the stdexec build so that it should only have to be built once.
The first build will fail until this change is rebased on #2307.