Repository navigation
Honor spec.gds.imagePullPolicy in NVIDIADriver DaemonSet - #3216
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review. Walkthrough
Severity of issue fixed: Medium Merge Risk:
 |
|
Thanks @Ajax-1, please make sure your commits are signed. |
0ba4ac6 to
6baaf84
Compare
The nvidia-fs-ctr container hardcoded imagePullPolicy to IfNotPresent, so the policy set in NVIDIADriver spec.gds.imagePullPolicy was ignored. Render the configured value and keep IfNotPresent as the default, matching the GDRCopy container. Signed-off-by: Ajax-1 <85230126+Ajax-1@users.noreply.github.com>
|
Signed the commit with SSH and force-pushed. GitHub now shows it as Verified. I also signed the commit on #3215 the same way. |
|
/ok to test 6baaf84 |
Issue
Fixes #3200
Description
The
nvidia-fs-ctrcontainer inmanifests/state-driver/0500_daemonset.yamlhardcodedimagePullPolicy: IfNotPresent, sospec.gds.imagePullPolicyon an NVIDIADriver was ignored. It now renders the configured value and falls back toIfNotPresent, the same way the GDRCopy container does.The ClusterPolicy path (
assets/state-driver) already handles this and is unchanged.Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Added
TestDriverGDSImagePullPolicyininternal/state/driver_test.go. It renders the driver DaemonSet with GDS enabled and checks thenvidia-fs-ctrpull policy for omitted,IfNotPresent,AlwaysandNever. Without the template change, theAlwaysandNevercases fail. The existingdriver-gdsgolden file is unchanged, since the policy is omitted there.make unit-testpassesmake lintpasses