Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Build a separate jar for each Lucene minor release from 10.2 to 10.5, since Lucene changes its codec APIs between minor releases. All modules compile the same shared sources. Codecs built on an older Lucene release's default codec stay registered so existing indexes can still be read, but they can no longer write. Fixes NVIDIA#2410
imotov
force-pushed
the
issue-2410-support-multiple-lucene-versions
branch
from
September 30, 2026 02:46
75b3caf to
ee335be
Compare
Contributor
Author
|
/ok to test ee335be |
… improve robustness of builds.
…multiple-lucene-versions
Contributor
Author
|
/ok to test b10ab96 |
Contributor
Author
|
/ok to test 71b6640 |
Lucene 10.4+ sizes the merged graph from the M recorded in a source segment's metadata. If that M falls below maxConn, which happens for small segments where cuVS truncates the graph degree, CPU merges of such segments fail. Always record an M of at least maxConn, as Lucene's own HNSW writer does.
It will only make the same query to run twice.
…multiple-lucene-versions
Contributor
Author
|
/ok to test f2db35d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build a separate jar for each Lucene minor release from 10.2 to 10.5, since Lucene changes its codec APIs between minor releases. All modules compile the same shared sources. Codecs built on an older Lucene release's default codec stay registered so existing indexes can still be read, but they can no longer write.
Fixes #2410