feat(docker): support corporate proxy CA bundles by feloy · Pull Request #3549 · NVIDIA/OpenShell

feloy · 2026-09-22T13:39:34Z

🏗️ build-from-issue-agent

Summary

Add explicit custom CA bundle support for Docker compute-driver corporate forward proxies. The gateway validates and stages the operator-owned bundle into the supervisor archive at a fixed internal path without exposing the host path to sandbox workloads.

Related Issue

Closes #3545

Changes

Add and validate the Docker proxy_ca_bundle configuration.
Revalidate and package the CA bundle for each supervisor archive with fixed ownership, permissions, and argv.
Render OPENSHELL_SANDBOX_PROXY_CA_BUNDLE in the Docker gateway task.
Add unit coverage and a Docker corporate-proxy E2E suite covering CONNECT authentication, policy enforcement, HTTPS proxy trust, TLS interception, workload trust, and fail-closed configuration.
Document the Docker trust contract in driver, reference, architecture, and debugging documentation.

Testing

mise run pre-commit passes
Unit tests added/updated
E2E tests added/updated (if applicable)
cargo test -p openshell-driver-docker — 125 passed
cargo test --manifest-path e2e/rust/Cargo.toml --features e2e-docker --test docker_corporate_proxy --no-run
bash -n tasks/scripts/gateway-docker.sh
OPENSHELL_E2E_DOCKER_TEST=docker_corporate_proxy mise run e2e:docker — not run locally because the Docker CLI/daemon is unavailable. Podman is installed, but aliasing it as Docker would not validate the Docker runtime/socket semantics exercised by this path.

Checklist

Follows Conventional Commits
Commits are signed off (DCO)
Architecture docs updated (if applicable)

copy-pr-bot · 2026-09-22T13:39:38Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

johntmyers · 2026-09-25T21:16:58Z

gator-agent

Blocked

Gator is blocked because the current branch conflicts with main, so the effective patch cannot enter code review or CI dispatch yet.

Next action: @feloy, rebase or merge the latest main, resolve the conflicts, and push the updated branch.

Gator metadata

Head SHA: e32416209432c32554abd527b70d62dd108ad2c6
Gator payload: 9
Next state: gator:blocked
Blocked reason: merge_conflict

Closes NVIDIA#3545 Validate and stage operator-owned proxy CA bundles for Docker supervisors, add corporate proxy E2E coverage, and document the trust contract. Signed-off-by: Philippe Martin <phmartin@redhat.com>

johntmyers · 2026-09-25T21:32:03Z

/ok to test 9b05d9f

github-actions · 2026-09-25T21:32:31Z

Label test:e2e applied for 9b05d9f. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

johntmyers

gator-agent

PR Review Status

The merge conflict is resolved and the full current patch has been reviewed. One startup-path consistency issue still needs an author update before Gator can hand the PR to pipeline monitoring.

Action required: @feloy, make the standalone Docker driver reject incoherent proxy CA configuration during startup and add regression coverage for that entry point.

Blocking findings:

GATOR-9b05d9f4-01: the standalone Docker driver bypasses the new proxy CA configuration validation.

Carried findings:

None

Gator metadata

Validation: Project-valid implementation of linked issue #3545; scope matches the Docker corporate-proxy trust contract.
Docs: Fern documentation and operator diagnostics are updated for the new Docker configuration.
Checks: Current-head branch checks and E2E are queued or running.
E2E: test:e2e applied; /ok to test accepted; Branch E2E Checks run 36192072961 is queued as attempt 2.
Head SHA: 9b05d9f4c89ff1596d3cc9ac7b68ac3398756931
Base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Merge base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Patch ID: b2506fc4796c4bbd5ef3862c347c25da077c14bc
Gator payload: 9
Review mode: initial
Previous reviewed SHA: none
Review budget exhausted: no
Maintainer decision required: no
Next state: gator:in-review

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers · 2026-09-25T22:40:52Z

/ok to test 30f1c90

johntmyers

gator-agent

PR Review Status

The follow-up review confirms that the standalone Docker constructor now validates the full proxy configuration before Docker I/O, with targeted regression coverage. The prior startup-validation finding is resolved and no code-review blockers remain, but the required current-head Docker E2E job failed before Gator could complete pipeline monitoring.

Action required: @NVIDIA/openshell-maintainers, inspect the docker-e2e / E2E (rust-docker) failure in run 36197865788 and either rerun it if the failure is flaky or infrastructure-related, or request the corresponding author fix.

Blocking findings:

No blocking code-review findings remain.

Carried findings:

GATOR-9b05d9f4-01: resolved by routing DockerComputeDriver::new through validate_configuration and adding constructor regression coverage.

Gator metadata

Validation: Project-valid implementation of linked issue #3545; scope matches the Docker corporate-proxy trust contract.
Docs: Fern documentation and operator diagnostics are updated for the Docker configuration.
Checks: Branch Checks, Helm Lint, and DCO are green; required OpenShell / E2E is failing because docker-e2e / E2E (rust-docker) exited with code 101.
E2E: test:e2e is applied and the current-head workflow completed; detailed job logs are unavailable to this sandbox, and no current-head E2E Label Help instruction requested a rerun.
Head SHA: 30f1c906207c0bbaef3bdc2d18c418bef6ad03f3
Base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Merge base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Patch ID: 131c7faac70146a6e2080862943e78b7f31dc958
Gator payload: 9
Review mode: follow_up
Previous reviewed SHA: 9b05d9f4c89ff1596d3cc9ac7b68ac3398756931
Review budget exhausted: no
Maintainer decision required: no
Next state: gator:blocked
Blocked reason: e2e_failure_diagnosis_required

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers · 2026-09-26T00:38:24Z

/ok to test d9b608b

johntmyers

gator-agent

PR Review Status

Thanks @johntmyers. I checked your current-head update that replaces the explicit --from base arguments with the harness-managed E2E workload image in all three Docker corporate-proxy scenarios. It addresses the prior rust-docker environment mismatch without reopening the resolved startup-validation finding, and no code-review blockers remain.

Action required: @NVIDIA/openshell-maintainers, approve the current-head Trivy Changes workflow run 36205578960 so the required security check can execute. Gator will also continue watching the active Branch E2E run 36205590139.

Blocking findings:

No blocking code-review findings remain.

Carried findings:

GATOR-9b05d9f4-01: remains resolved; this E2E-only delta does not alter Docker configuration validation.

Gator metadata

Validation: Project-valid implementation of linked issue #3545; scope remains within the Docker corporate-proxy trust contract.
Docs: Fern documentation and operator diagnostics are updated for the Docker configuration.
Checks: Branch Checks, Helm Lint, and DCO are green; Branch E2E is active; the required Trivy workflow is awaiting maintainer approval.
E2E: test:e2e is applied, /ok to test d9b608b0987764f84da13cb7a7878dba92a617f8 refreshed the mirror, and current-head Branch E2E run 36205590139 is in progress.
Head SHA: d9b608b0987764f84da13cb7a7878dba92a617f8
Base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Merge base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Patch ID: 5814d4d9c02c0e874e4d87753f05d9a88caf159d
Gator payload: 9
Review mode: follow_up
Previous reviewed SHA: 30f1c906207c0bbaef3bdc2d18c418bef6ad03f3
Review budget exhausted: no
Maintainer decision required: no
Next state: gator:blocked
Blocked reason: trivy_workflow_approval_required

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers · 2026-09-26T08:48:27Z

/ok to test 9283d28

johntmyers

gator-agent

PR Review Status

I checked @johntmyers's current-head update that surfaces TLS-interception fixture errors in proxy logs and assertion output. The critical-only delta review found no new Critical defect, the earlier startup-validation finding remains resolved, and no maintainer convergence decision is needed.

Action required: @NVIDIA/openshell-maintainers, approve the current-head Trivy Changes workflow run 36230881275 so the required security check can execute. Branch Checks and the required E2E workflow are already running.

Blocking findings:

No blocking code-review findings remain.

Carried findings:

GATOR-9b05d9f4-01: remains resolved; this E2E diagnostic-only delta does not alter Docker configuration validation.

Gator metadata

Validation: Project-valid implementation of linked issue #3545; scope remains within the Docker corporate-proxy trust contract.
Docs: Fern documentation and operator diagnostics are updated for the Docker configuration.
Checks: Branch Checks and E2E are active; Helm Lint and DCO are green; required Trivy Changes awaits maintainer workflow approval.
E2E: test:e2e is applied, /ok to test 9283d28aa56447dae20c93b13558ae57b1af53b6 refreshed the mirror, and current-head Branch E2E run 36230890328 is in progress.
Head SHA: 9283d28aa56447dae20c93b13558ae57b1af53b6
Base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Merge base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Patch ID: c42872a1f59746e40c071c331c2397dea86d3e94
Gator payload: 9
Review mode: critical_only
Previous reviewed SHA: a70b6973d2d3ed012e8348d799b484c31b222fd5
Review budget exhausted: yes
Maintainer decision required: no
Next state: gator:blocked
Blocked reason: trivy_workflow_approval_required

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers · 2026-09-26T09:50:50Z

/ok to test 9ea5b0c

johntmyers

gator-agent

PR Review Status

Thanks @johntmyers. I checked your current-head update that drains already-decrypted TLS bytes before the proxy fixture waits on the underlying sockets. The critical-only delta review found no new Critical defect, the earlier startup-validation finding remains resolved, and no maintainer convergence decision is needed.

Action required: @NVIDIA/openshell-maintainers, approve the current-head Trivy Changes workflow run 36233996817 so the required security check can execute. Branch Checks and Helm Lint are green, and the required E2E workflow is active.

Blocking findings:

No blocking code-review findings remain.

Carried findings:

GATOR-9b05d9f4-01: remains resolved; this E2E fixture delta does not alter Docker configuration validation.

Gator metadata

Validation: Project-valid implementation of linked issue #3545; scope remains within the Docker corporate-proxy trust contract.
Docs: Fern documentation and operator diagnostics are updated for the Docker configuration.
Checks: Branch Checks and Helm Lint are green; E2E is active; required Trivy Changes awaits maintainer workflow approval.
E2E: test:e2e is applied, /ok to test 9ea5b0cfd20a86593e0e65157e93542c228e609c refreshed the mirror, and current-head Branch E2E run 36234007284 is in progress.
Head SHA: 9ea5b0cfd20a86593e0e65157e93542c228e609c
Base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Merge base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Patch ID: 0c86f54b7f6fc899bd7ec95130db46ecd2152cff
Gator payload: 9
Review mode: critical_only
Previous reviewed SHA: 9283d28aa56447dae20c93b13558ae57b1af53b6
Review budget exhausted: yes
Maintainer decision required: no
Next state: gator:blocked
Blocked reason: trivy_workflow_approval_required

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers · 2026-09-26T10:49:40Z

/ok to test 6b9f004

johntmyers

gator-agent

PR Review Status

I checked the current-head update that replaces the bidirectional intercepted-TLS relay with a deterministic one-request HTTP relay. The critical-only delta review found no new Critical defect, the earlier startup-validation finding remains resolved, and no maintainer convergence decision is needed.

Action required: @NVIDIA/openshell-maintainers, approve the current-head Trivy Changes workflow run 36236954334 so the required security check can execute. Branch Checks and the required E2E workflow are already running.

Blocking findings:

No blocking code-review findings remain.

Carried findings:

GATOR-9b05d9f4-01: remains resolved; this E2E fixture delta does not alter Docker configuration validation.

Gator metadata

Validation: Project-valid implementation of linked issue #3545; scope remains within the Docker corporate-proxy trust contract.
Docs: Fern documentation and operator diagnostics are updated for the Docker configuration.
Checks: Branch Checks and E2E are active; Helm Lint and DCO are green; required Trivy Changes awaits maintainer workflow approval.
E2E: test:e2e is applied, /ok to test 6b9f004eb553e86de474dbe4dc60c982a5029a09 refreshed the mirror, and current-head E2E is in progress.
Head SHA: 6b9f004eb553e86de474dbe4dc60c982a5029a09
Base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Merge base SHA: 496ebba293f5cc2bb2753444dddd534f0b4aeb6a
Patch ID: 2d81b60abc3dc93ad18badedd98f62de7ffc2862
Gator payload: 9
Review mode: critical_only
Previous reviewed SHA: 9ea5b0cfd20a86593e0e65157e93542c228e609c
Review budget exhausted: yes
Maintainer decision required: no
Next state: gator:blocked
Blocked reason: trivy_workflow_approval_required

feloy requested review from a team, derekwaynecarr, mrunalp and sjenning as code owners September 22, 2026 13:39

johntmyers added the gator:blocked Gator is blocked by process or repository gates label Sep 25, 2026

johntmyers self-assigned this Sep 25, 2026

feat(docker): support corporate proxy CA bundles

9b05d9f

Closes NVIDIA#3545 Validate and stage operator-owned proxy CA bundles for Docker supervisors, add corporate proxy E2E coverage, and document the trust contract. Signed-off-by: Philippe Martin <phmartin@redhat.com>

johntmyers force-pushed the feat/proxy-docker branch from e324162 to 9b05d9f Compare September 25, 2026 21:31

johntmyers added the test:e2e Requires end-to-end coverage label Sep 25, 2026

johntmyers reviewed Sep 25, 2026

View reviewed changes

Comment thread crates/openshell-driver-docker/src/lib.rs

johntmyers added gator:in-review Gator is reviewing or awaiting PR review feedback and removed gator:blocked Gator is blocked by process or repository gates labels Sep 25, 2026

fix(docker): validate proxy config on startup

30f1c90

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers reviewed Sep 25, 2026

View reviewed changes

test(docker): use the E2E workload image for proxy tests

d9b608b

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers reviewed Sep 26, 2026

View reviewed changes

test(docker): surface intercepted TLS fixture errors

9283d28

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers reviewed Sep 26, 2026

View reviewed changes

test(docker): drain buffered TLS proxy data

9ea5b0c

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers reviewed Sep 26, 2026

View reviewed changes

test(docker): relay intercepted HTTP deterministically

6b9f004

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>

johntmyers reviewed Sep 26, 2026

View reviewed changes

johntmyers approved these changes Sep 28, 2026

View reviewed changes

johntmyers added this pull request to the merge queue Sep 28, 2026

johntmyers added gator:merge-ready and removed gator:approval-needed Gator completed review; maintainer approval needed labels Sep 28, 2026

github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Sep 28, 2026

Conversation

feloy commented Sep 22, 2026

Summary

Related Issue

Changes

Testing

Checklist

Uh oh!

copy-pr-bot Bot commented Sep 22, 2026

Uh oh!

johntmyers commented Sep 25, 2026

Blocked

Uh oh!

johntmyers commented Sep 25, 2026

Uh oh!

github-actions Bot commented Sep 25, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

Uh oh!

johntmyers commented Sep 25, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers commented Sep 26, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers commented Sep 26, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers commented Sep 26, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

johntmyers commented Sep 26, 2026

Uh oh!

johntmyers left a comment

Choose a reason for hiding this comment

PR Review Status

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants