Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Unmigrated consumers of removed imports, APIs, and YAML support cause runtime failures and prevent test collection.
4 open issues
What changed in this PR
Retires the legacy YAML combiner for issue #993 and makes the existing uwtools-based implementation the standard combiner used by FRE.
Changes:
- Removes the legacy command, parser classes, abstract classes, and
!joinconstructor. - Moves the replacement combiner to the canonical module name and updates list, post-processing, and test imports.
- Switches the shared YAML loader to
safe_loadand removes obsolete documentation.
| File | Description |
|---|---|
fre/yamltools/tests/test_combine_yamls_script.py |
Updates the combiner import. |
fre/yamltools/README.md |
Removes legacy command documentation. |
fre/yamltools/info_parsers/pp_info_parser.py |
Deletes the legacy post-processing parser. |
fre/yamltools/info_parsers/compile_info_parser.py |
Deletes the legacy compilation parser. |
fre/yamltools/info_parsers/analysis_info_parser.py |
Deletes the legacy analysis parser. |
fre/yamltools/helpers.py |
Uses safe loading and removes experiment checking. |
fre/yamltools/freyamltools.py |
Removes the legacy command and redirects combine. |
fre/yamltools/constructors.py |
Deletes the !join constructor. |
fre/yamltools/combine_yamls_script.py |
Replaces the legacy implementation with the uwtools combiner. |
fre/yamltools/combine_yamls_script_new.py |
Removes the former replacement-module location. |
fre/yamltools/abstract_classes.py |
Deletes legacy merging interfaces. |
fre/yamltools/__init__.py |
Disables constructor registration and the YAML import. |
fre/pp/tests/test_configure_script_yaml.py |
Updates the test combiner import. |
fre/pp/configure_script_yaml.py |
Updates the post-processing combiner import. |
fre/list_/list_pp_components_script.py |
Updates the component-listing combiner import. |
fre/list_/list_platforms_script.py |
Updates the platform-listing combiner import. |
fre/list_/list_experiments_script.py |
Updates the experiment-listing combiner import. |
Review effort: Balanced
…inghd789/fre-cli into 993.remove-old-combiner
singhd789
marked this pull request as ready for review
October 28, 2026 19:33
…inghd789/fre-cli into 993.remove-old-combiner
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Describe your changes
Needs this PR merged in first (for failing fre make tests): #999
Issue ticket number and link (if applicable)
Fixes #993
Checklist before requesting a review
Note: If you are a code maintainer updating the tag or releasing a new fre-cli version, please use the
release_procedure.mdtemplate. To quickly use this template, open a new pull request, choose your branch, and add?template=release_procedure.mdto the end of the url.