[ravimnm]

Summary

• Return an unmodifiable view from HashSetReferenceInfo.getReferences() to prevent callers from modifying the internal reference list.
• Add a regression test verifying that the returned list cannot be modified and reflects references added through addReference().

Testing

• mvn -Dtest=HashSetReferenceInfoTest test — passed (1 test).
• mvn test — the full suite did not complete successfully; the Cucumber test process terminated after Windows-path URI errors and registry-related test output.

Related issue

Fixes #1618

[jordanpadams]

Thanks for the PR! The change itself looks good and the test covers it. One small update requested (see the inline comment on the test), plus one observation:

getReferences() doesn't appear to be called anywhere in src/ - ReferentialIntegrityUtil only uses doesReferenceExist() and addReference(). That means this hardening doesn't affect any current code path, and the method can probably be removed altogether rather than made unmodifiable. Happy to go either way, but if you agree it's unused, removing it (and this test) may be the cleaner resolution for #1618.

🤖 Generated with help from Claude Code

[jordanpadams]

Please replace throws Exception with the specific checked exception that can actually be thrown here. Only new URL(String) throws one, so throws java.net.MalformedURLException is enough. We avoid declaring generic Exception types.

🤖 Generated with help from Claude Code

[ravimnm]

Thanks for the review! I checked the repository for usages of HashSetReferenceInfo.getReferences() and confirmed that it isn't used by the current source code. I agree that removing the unused getter is cleaner, so I've removed it along with the regression test.

The updated code compiles successfully with mvn -DskipTests compile. The full test suite still encounters the existing Windows-path URI and Cucumber integration-test issues on my environment.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud