Repository navigation
Port the ES8311 audio-reactive board definition to the Waveshare ESP3… - #130
Open
TouchMyLight wants to merge 1 commit into
Open
TouchMyLight wants to merge 1 commit into
TouchMyLight wants to merge 1 commit into
Conversation
…2-P4-ETH Writes the hardware reference page for the Waveshare ESP32-P4-ETH's onboard ES8311 codec and Ethernet wiring, which PR MoonModules#128's firmware-variant approach never landed on main after PR MoonModules#129 made the codec runtime configuration. Also renames the shared P4 Ethernet preset to "P4-NANO/ETH" so its UI label doesn't imply it's NANO-only. **Core** - `EthernetModule.h`: `kEthPresets`' shared P4 RMII row renamed `"P4-NANO"` → `"P4-NANO/ETH"`, naming both boards that use it; doc comment updated to match. **Scripts/MoonDeck** - `check_devices.py`: its own restatement of the preset label (cross-checked against `platform_config.h`'s chip default) updated to match the rename — this is the check that caught the miss on the first pass. **Docs/CI** - New `docs/reference/hardware/esp32-p4-eth.md`: audio (ES8311) and Ethernet pin tables, free-GPIO table, bench-verification notes, written against the current runtime-codec architecture (`AudioService`/`I2cBusModule`), not copied from the closed PR MoonModules#128. - `firmware-variants.md`, `gpio-usage.md`: P4-ETH named alongside the P4-NANO as sharing `esp32p4rev1-eth`. - `mkdocs.yml`: nav entry for the new page. - `mooninstaller/deviceModels.json`: the renamed preset label carried into all 5 P4-family catalog entries that reference it. Bench-verified on the Waveshare ESP32-P4-ETH (plain `esp32p4rev1-eth` firmware, no new variant): I2C bus scan ACKs the codec at 0x18, `AudioService` reports live mic data, Ethernet link + DHCP hold, and the renamed preset round-trips cleanly on an already-provisioned board (auto-resolves to the new label, same pins, no reseed to Custom). Reviews - Pre-existing, unrelated to this diff (confirmed by reproducing on a clean `main`): `check_docgen` carries 1 pre-existing error (`Hub75Slots.h`) and `check_code` a 4-finding drift, both from commits already on `main` before this branch started — named here rather than fixed, since neither file is touched by this change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Author
|
note: the ESP32-P4-ETH definition is important for an upcoming PR using this board: a MountSd service to use the microSD slot on this board |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…2-P4-ETH
Writes the hardware reference page for the Waveshare ESP32-P4-ETH's onboard ES8311 codec and Ethernet wiring, which PR #128's firmware-variant approach never landed on main after PR #129 made the codec runtime configuration. Also renames the shared P4 Ethernet preset to "P4-NANO/ETH" so its UI label doesn't imply it's NANO-only.
Core
EthernetModule.h:kEthPresets' shared P4 RMII row renamed"P4-NANO"→"P4-NANO/ETH", naming both boards that use it; doc comment updated to match.Scripts/MoonDeck
check_devices.py: its own restatement of the preset label (cross-checked againstplatform_config.h's chip default) updated to match the rename — this is the check that caught the miss on the first pass.Docs/CI
docs/reference/hardware/esp32-p4-eth.md: audio (ES8311) and Ethernet pin tables, free-GPIO table, bench-verification notes, written against the current runtime-codec architecture (AudioService/I2cBusModule), not copied from the closed PR Add ES8311 audio-reactive support for the Waveshare ESP32-P4-ETH #128.firmware-variants.md,gpio-usage.md: P4-ETH named alongside the P4-NANO as sharingesp32p4rev1-eth.mkdocs.yml: nav entry for the new page.mooninstaller/deviceModels.json: the renamed preset label carried into all 5 P4-family catalog entries that reference it.Bench-verified on the Waveshare ESP32-P4-ETH (plain
esp32p4rev1-ethfirmware, no new variant): I2C bus scan ACKs the codec at 0x18,AudioServicereports live mic data, Ethernet link + DHCP hold, and the renamed preset round-trips cleanly on an already-provisioned board (auto-resolves to the new label, same pins, no reseed to Custom).Reviews
main):check_docgencarries 1 pre-existing error (Hub75Slots.h) andcheck_codea 4-finding drift, both from commits already onmainbefore this branch started — named here rather than fixed, since neither file is touched by this change.