Repository navigation
Conversation
…nToClient during domain reload
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetworkIdentity._connectionToClientis a private field of a[Serializable]type. On domain reload Unity backs up and restores such fields, which constructs aNetworkConnectionToClientthrough its parameterless constructor. That chains intoNetworkConnection(), which readsTime.time, and Unity throws "get_time is not allowed to be called during serialization".The field is runtime-only state, so it is now marked
[NonSerialized]. This is the fix suggested in the issue.I could not run this in the Unity editor; the change is the single attribute.
Closes #4131