Repository navigation
fix: #4125 return unread unbatcher writers to the pool on disconnect - #4132
Merged
miwarnec merged 1 commit intoNov 6, 2026
Merged
Conversation
…l on disconnect and client reinitialize
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unread batches queued in an
Unbatcherhold pooledNetworkWriterPooledinstances. They were never returned when the connection went away, so the pool lost one writer (with its expanded buffer) per such disconnect.Server:
NetworkConnection.Cleanup()only cleared the send-side batchers.NetworkConnectionToClientnow overridesCleanup()and clearsunbatcher.OnTransportDisconnectedalways callsCleanup(), so this also covers theUnpackAndInvokefailure path, which callsDisconnect()and returns without clearing.Client:
NetworkClient.Initialize()andShutdown()replacedunbatcherwith a new instance and dropped the old queue. They now callClear()first.Verification: I added
Cleanup_ClearsUnbatchertoNetworkConnectionToClientTests. I could not run it because I have no Unity Editor here, so this is untested in Unity. The change is threeClear()calls on an existing method, and the diff is 25 added lines.Closes #4125