Repository navigation
Conversation
ch-z-hc
marked this pull request as ready for review
October 14, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
After setting
default_video_modeltoMiniMax-Hailuo-2.3-Fast,mmx video generate --prompt "A cat"submits a task without an image. The existing image requirement checks only the explicit--modelflag, so it is bypassed when the same model comes from config.Fix
Apply the existing guard to the resolved model. One product line changes; model precedence and automatic SEF/S2V selection stay unchanged.
The regression executes the command against a local HTTP fixture: original code submits a task; patched code returns usage error 2 with zero task submissions. Five controls cover
--image, the hidden--first-framealias, explicit model override, and SEF/S2V switching. A separate real CLI dry-run reads a temporary config file: original exits 0 with an invalid request preview, patched exits 2 with the existing image-required error.This prevents task submission, not every network operation during CLI startup: existing authentication, region detection and update checks are outside this patch.
Validation
speech.test.tswarning. Linux production build and compiled CLI version check pass.a965e72in the same environment: 596 passed, the same 3 failed (unreachable-region timeouts intimeout-fix.test.tsandauth/login.test.ts, and the FileSDK upload base-URL assertion). Their causes were not diagnosed here. Both use the same validation-only fetch preload rejecting non-loopback destinations by default; test-owned mocks can override it. No repository assertions, timeouts or skip conditions were relaxed.No live MiniMax model calls. Implemented and tested with Codex assistance; the independent blind reviews were automated, not human approval.
Need help on this PR? Tag
@codesmith-botwith what you need.