Repository navigation
Conversation
ch-z-hc
marked this pull request as ready for review
October 14, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
With
--subtitles --out session.v1/clip, synthesis saves the audio at the requested path but writes the subtitle tosession.srtin the parent directory. The extension-removal regex matches across path separators when the audio filename has no extension. A hidden filename such as.clipalso loses its name.Fix
Use Node's
path.extname()to remove only the filename's extension, leaving the directory and the rest of the path unchanged. No changes to fetching, audio output, or subtitle conversion.Four regressions execute the actual synthesis command against a local HTTP fixture and check audio/subtitle contents, printed paths, and that no file appeared in the parent directory. They cover ordinary, multi-dot, extensionless, and hidden filenames under a dotted directory. On the original code, the two extensionless cases fail and the two compatibility cases pass; all four pass with the fix.
Validation
speech.test.tswarning.mmx --versionpass.a965e72under the same runtime has 596 passed, the same 3 failed: unreachable-region timeouts intimeout-fix.test.tsandauth/login.test.ts, plus the FileSDK upload base-URL assertion. These failures are not fixed or diagnosed here. Both runs use the same validation-only fetch preload rejecting non-loopback destinations; no repository tests or timeouts were relaxed.No live MiniMax service calls. Implemented and tested with Codex assistance; the independent blind reviews were automated, not human review.
Need help on this PR? Tag
@codesmith-botwith what you need.