Repository navigation
Unify platform settings and workspace storage configuration - #689
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings now provides one editing home for sandbox scheduling and per-node capacity, workspace storage, default models and credentials, and service installation facts. Nodes and monitoring keep operational views and link to the canonical settings forms. Existing resource APIs and lifecycle semantics are unchanged.
Workspace storage uses the existing immutable-selection API: tenant capacity can be edited separately, while selecting new storage accepts the adapter's documented parameters and write-only credentials. Observing a changed selection invalidates an open capacity form. Startup configuration remains read-only. English and Chinese operator documentation follows the same page names and ownership.
Validation: Web/client typechecks, 392 Web and 727 client unit tests, production Web build, 88 browser cases (including enrollment, node history navigation, storage retry and observed concurrent selection), website build and 22 bilingual documentation/website checks. Fresh independent review found no remaining in-scope defects. Existing storage PUT remains last-writer-wins for unseen concurrent writes; atomic conflict detection requires a separate protocol change. Request tracing is a separately assessed follow-up, not part of this change.