Skip to content

Preserve the console route when skipping to main content - #422

Open
dvd233 wants to merge 3 commits into
MiniMax-AI:mainfrom
dvd233:fix/console-skip-link-route-421
Open

dvd233 wants to merge 3 commits into
MiniMax-AI:mainfrom
dvd233:fix/console-skip-link-route-421

Conversation

@dvd233

@dvd233 dvd233 commented Oct 6, 2026 •

Copy link
Copy Markdown

Fixes #421.

Summary

Activating “Skip to main content” currently replaces the console route fragment with #main-content, which the router resolves to Overview. Prevent the anchor’s fragment navigation and focus the existing main element instead, preserving the current hash, project/resource parameters and browser history.

The change keeps the existing link, main ID, focus styling, tabIndex and normal navigation behavior.

Regression coverage

  • Tab and Enter from Files, visible skip-link focus, focus on the same main element, and keyboard continuation inside main.
  • Click and Enter on a parameterized Agent detail page, repeated activation, and browser Back/Forward and the page’s Back action.
  • Tour replacement and return, followed by focus on the remounted console main.

Validation

Source-bound fork CI, testing b835fea5e6140dbab8529404f2fd23704ba96dd1:

  • The same three regressions fail on unchanged base 9fa92df0afb170bd57da8314e2a4280aca1fd4ac with the expected #main-content URL mismatch, and pass on the candidate.
  • All 83 Web browser acceptance tests pass.
  • make check-web-unit passes: typechecks, client/Web unit tests and production build.
  • make check-names check-docs check-ci passes.

Browser acceptance uses the repository’s synthetic console fixture. The separate fork validation workflow is not part of this PR.

Implemented and tested with AI assistance.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@dvd233
dvd233 marked this pull request as ready for review October 6, 2026 04:22
@SaladDay
SaladDay enabled auto-merge (squash) October 7, 2026 06:29
@SaladDay

SaladDay commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Thanks for the fix! LGTM.

Could you update your branch with main? We can merge once CI passes.

@dvd233

dvd233 commented Oct 13, 2026

Copy link
Copy Markdown
Author

Merged current upstream main (14035a2bdb277d235d62e725ffea2832c2dc9f39) into this branch with merge commit 345301df1c348896a2b6fb3baa167ab1ee0076da, preserving the existing commits (normal push, no rebase). The diff against main remains the skip-link fix and its three regression tests.

Validation on Windows: Web/client typechecks and production build pass; all three skip-link browser regressions pass; 744 client unit tests pass. Web unit results match unchanged main (378 pass, 14 POSIX-shell-dependent failures). The name scan passes; Python guard/doc/CI tests have the same Windows-specific failures on unchanged main. The broader browser run reached all 96 cases and exposed one dialog-backdrop strict-locator failure, also reproduced on unchanged main; its server teardown did not exit, so I am not reporting that run as fully passing.

The upstream core-check run for this exact commit is currently action_required: https://github.com/MiniMax-AI/OpenAgentCore/actions/runs/38373597393 . Please approve the workflow when convenient so the Linux CI can validate the updated branch.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip to content changes the console page to Overview

2 participants