Repository navigation
Conversation
|
Thanks for the fix! LGTM. Could you update your branch with main? We can merge once CI passes. |
|
Merged current upstream main ( Validation on Windows: Web/client typechecks and production build pass; all three skip-link browser regressions pass; 744 client unit tests pass. Web unit results match unchanged main (378 pass, 14 POSIX-shell-dependent failures). The name scan passes; Python guard/doc/CI tests have the same Windows-specific failures on unchanged main. The broader browser run reached all 96 cases and exposed one dialog-backdrop strict-locator failure, also reproduced on unchanged main; its server teardown did not exit, so I am not reporting that run as fully passing. The upstream |
Fixes #421.
Summary
Activating “Skip to main content” currently replaces the console route fragment with
#main-content, which the router resolves to Overview. Prevent the anchor’s fragment navigation and focus the existing main element instead, preserving the current hash, project/resource parameters and browser history.The change keeps the existing link, main ID, focus styling, tabIndex and normal navigation behavior.
Regression coverage
Validation
Source-bound fork CI, testing
b835fea5e6140dbab8529404f2fd23704ba96dd1:9fa92df0afb170bd57da8314e2a4280aca1fd4acwith the expected#main-contentURL mismatch, and pass on the candidate.make check-web-unitpasses: typechecks, client/Web unit tests and production build.make check-names check-docs check-cipasses.Browser acceptance uses the repository’s synthetic console fixture. The separate fork validation workflow is not part of this PR.
Implemented and tested with AI assistance.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.