Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an opt-in vulnerability scan for images built by
mctf build, using Trivy to identify vulnerabilities in container images. This introduces SEC006 and allows users to fail a build when vulnerabilities meet the configured severity threshold, without requiring Trivy for users who don't enable the feature.Closes #46
How
--scan-vulnsto enable vulnerability scanning after images are built.--vuln-severityto configure the severity threshold, defaulting toHIGH,CRITICAL.internal/build.docs/spec/validation.mdand updated the build command help.Verification
go build ./...go test ./...fails on Windows in internal/instancer (plugin script execution) and internal/kubernetes (path separator assumptions); the SEC006-related tests passgolangci-lint run ./...0 issuesmctf generate --checkon the sample event (not applicable; no generated files changed)docs/spec/validation.md)make schemassynced (not applicable; no schema changes)Notes