Repository navigation
fix: don't mark read-only workspace queries as unsaved - #194
Merged
Merged
Conversation
Edits to a query opened from a read-only workspace can never be saved back, so the tab no longer shows the unsaved dot and closing it no longer asks to save. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01StQ5dk15ErNgjFnErZ7ce4
MathiasVDA
added a commit
that referenced
this pull request
Oct 11, 2026
Edits to a query opened from a read-only workspace can never be saved back, so the tab no longer shows the unsaved dot and closing it no longer asks to save.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Mathias · project thread
Follow-up to #193 (#187).
Before: after a query opened from a read-only workspace was edited, either by the user or by the parser or formatter when the query ran, its tab showed the unsaved dot, and closing the tab asked whether to save.
After: tabs holding a query from a read-only workspace never count as unsaved. No dot appears, and the tab closes without asking.
How:
Tab.hasUnsavedManagedChanges()returns false when the tab's workspace is read-only. Both the tab's dirty marker (TabElements) and the close prompt use this method. The user guide and a patch changeset are updated to match.The unit tests pass (1679). I have not checked it in a browser.
🤖 Generated with Claude Code
https://claude.ai/code/session_01StQ5dk15ErNgjFnErZ7ce4
Generated by Claude Code