PoC: bare function vs class method - #236
Draft
matt-bernhardt wants to merge 1 commit into
Draft
matt-bernhardt wants to merge 1 commit into
matt-bernhardt wants to merge 1 commit into
Conversation
1 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This demonstrates the alternate way to implement a
register_blocks()call, changing from a bare function (directly in the plugin's root PHP script) to a method in the class file atsrc/class-heroimage.php.There are three conceptual changes here:
register_blocks()from a function in the root PHP script to a method in the PHP class.__DIR__ . '/build'pattern toplugin_dir_path( __DIR__ ) . 'build'. This is necessary because the method is one level deeper in the plugin, so we can't just "go down one level into the "build" folder" because now the code lives in thesrc/folder. There is an even more robust pattern we could use that would rely on a constant defined in the PHP script, but that really only becomes necessary if our plugins start getting into multi-level folder structures.add_action()call up to the rest of them, and update the instructions for where to find the thing being called - fromMitlib\PostTypes\register_blocksto `array( 'Mitlib\PostTypes\HeroImage', 'register_blocks' )