Conversation
The slices stopped at i + radius - 1, so the sample radius positions to the right was never compared. Use one loop over the whole signal; the third loop was unreachable (MIT-LCP#474). The test classes in test_processing.py were named test_*, which pytest does not collect, so rename them to make those tests run. Fixes MIT-LCP#572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #572. The window now covers
radiussamples on both sides like the docstring says, and the third loop that could never run is gone (#474).test_processing.py wasn't being collected because the classes were named
test_*, so I renamed them. The new test fails on main.XQRS uses
find_local_peaksfor its candidates, so its output shifts a little. On MIT-BIH 100, 101, 105, 108, 119, 200, 203, 207 and 208 it finds 21 fewer of 20856 beats (sensitivity 0.9777 to 0.9766), mostly in 208, and false positives stay at 733. If you'd rather keep XQRS as it was I can look at that side too.