Repository navigation
Pass Flux a valid --time-limit in the Tuolumne batch templates - #2033
Merged
Merged
Conversation
tuo.mako and tamd.mako wrote MFC's HH:MM:SS walltime straight into
"# flux: --time-limit=", which flux batch rejects ("invalid Flux standard
duration"), so ./mfc.sh run -e batch -c tuo|tamd failed at submission.
Convert it to seconds (e.g. 00:20:00 -> 1200s).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Claude Code Review Head SHA: 4eef203 Files changed:
Findings: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2032.
tuo.makoandtamd.makopassed MFC'sHH:MM:SSwalltime straight through as# flux: --time-limit=.flux batchrejects that format (invalid Flux standard duration), so./mfc.sh run -e batch -c tuoand-c tamdfailed at submission. Both templates now convert the walltime to seconds; for example,00:20:00becomes1200s.Note on the Codex review of #2032: queue detection works on Tuolumne. LC's Slurm-compatibility
sbatchwrapper (/usr/global/tools/flux_wrappers/bin/sbatch) is on PATH, soSLURMSystemis selected and submits through Flux. The failure was this walltime format.Testing
On Tuolumne pdebug:
./mfc.sh run benchmarks/5eq_rk3_weno3_hllc/case.py -e batch -c tamd -p pdebug -a brown -w 00:20:00 -N 1 -n 4 --gpu mp. The job was submitted as--time-limit=1200sand syscheck, pre_process, simulation (0.227 ns/gp/eq/rhs) and post_process all ran. Thetuotemplate has the identical change, but I did not test it.Acknowledgement