Skip to content

Pass Flux a valid --time-limit in the Tuolumne batch templates - #2033

Merged
sbryngelson merged 1 commit into
MFlowCode:masterfrom
sbryngelson:flux-walltime
Oct 11, 2026
Merged

sbryngelson merged 1 commit into
MFlowCode:masterfrom
sbryngelson:flux-walltime

Conversation

@sbryngelson

@sbryngelson sbryngelson commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #2032.

tuo.mako and tamd.mako passed MFC's HH:MM:SS walltime straight through as # flux: --time-limit=. flux batch rejects that format (invalid Flux standard duration), so ./mfc.sh run -e batch -c tuo and -c tamd failed at submission. Both templates now convert the walltime to seconds; for example, 00:20:00 becomes 1200s.

Note on the Codex review of #2032: queue detection works on Tuolumne. LC's Slurm-compatibility sbatch wrapper (/usr/global/tools/flux_wrappers/bin/sbatch) is on PATH, so SLURMSystem is selected and submits through Flux. The failure was this walltime format.

Testing

On Tuolumne pdebug: ./mfc.sh run benchmarks/5eq_rk3_weno3_hllc/case.py -e batch -c tamd -p pdebug -a brown -w 00:20:00 -N 1 -n 4 --gpu mp. The job was submitted as --time-limit=1200s and syscheck, pre_process, simulation (0.227 ns/gp/eq/rhs) and post_process all ran. The tuo template has the identical change, but I did not test it.


Acknowledgement

  • I confirm this PR meets the above expectations and reflects my own understanding and real-world context.

tuo.mako and tamd.mako wrote MFC's HH:MM:SS walltime straight into
"# flux: --time-limit=", which flux batch rejects ("invalid Flux standard
duration"), so ./mfc.sh run -e batch -c tuo|tamd failed at submission.
Convert it to seconds (e.g. 00:20:00 -> 1200s).
Copilot AI balanced review requested due to automatic review settings October 11, 2026 03:57
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@sbryngelson
sbryngelson merged commit cb2706b into MFlowCode:master Oct 11, 2026
20 checks passed
@github-actions

Copy link
Copy Markdown

Claude Code Review

Head SHA: 4eef203

Files changed:

  • 2
  • toolchain/templates/tamd.mako
  • toolchain/templates/tuo.mako

Findings:
No issues found. Checked toolchain/templates/tamd.mako and tuo.mako (the HH:MM:SS to seconds conversion in the flux time-limit line, with the default "01:00:00" from commands.py). Note: a walltime in "D-HH:MM:SS" form would raise a ValueError in int(), but the existing Slurm-style default doesn't use that form (low confidence it matters).

@sbryngelson
sbryngelson deleted the flux-walltime branch October 12, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants