Skip to content

Fix missing MPI broadcasts and serial collective results #2024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sbryngelson wants to merge 5 commits into
base: master
Choose a base branch
from
+12 −1
Draft

Fix missing MPI broadcasts and serial collective results #2024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d89091
Define result of scalar allreduce and gather helpers in non-MPI builds
sbryngelson Oct 9, 2026
1a45dba
Default and broadcast particle_cloud shell_axis in pre_process
sbryngelson Oct 10, 2026
1cf902b
Broadcast periodic_bc to all simulation ranks
sbryngelson Oct 10, 2026
8113b0d
Merge branch 'master' into consolidate/mpi-fixes
sbryngelson Oct 12, 2026
9ef4ba3
Merge branch 'master' into consolidate/mpi-fixes
sbryngelson Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/common/m_mpi_common.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,8 @@ contains

allocate (gathered_vector(sum(recounts)))
call MPI_GATHERV(my_vector, counts, mpi_p, gathered_vector, recounts, displs, mpi_p, root, MPI_COMM_WORLD, ierr)
#else
gathered_vector = my_vector
#endif

end subroutine s_mpi_gather_data
Expand Down Expand Up @@ -373,6 +375,8 @@ contains
integer :: ierr !< Generic flag used to identify and report MPI errors

call MPI_ALLREDUCE(var_loc, var_glb, 1, mpi_p, MPI_SUM, MPI_COMM_WORLD, ierr)
#else
var_glb = var_loc
#endif

end subroutine s_mpi_allreduce_sum
Expand Down Expand Up @@ -440,6 +444,8 @@ contains
integer :: ierr !< Generic flag used to identify and report MPI errors

call MPI_ALLREDUCE(var_loc, var_glb, 1, mpi_p, MPI_MIN, MPI_COMM_WORLD, ierr)
#else
var_glb = var_loc
#endif

end subroutine s_mpi_allreduce_min
Expand Down Expand Up @@ -470,6 +476,8 @@ contains
integer :: ierr !< Generic flag used to identify and report MPI errors

call MPI_ALLREDUCE(var_loc, var_glb, 1, mpi_p, MPI_MAX, MPI_COMM_WORLD, ierr)
#else
var_glb = var_loc
#endif

end subroutine s_mpi_allreduce_max
Expand Down
1 change: 1 addition & 0 deletions src/pre_process/m_global_parameters.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,6 +396,7 @@ contains
particle_cloud(i)%moving_ibm = 0
particle_cloud(i)%seed = 0
particle_cloud(i)%cloud_geometry = 1
particle_cloud(i)%shell_axis = 3
particle_cloud(i)%packing_method = dflt_int
particle_cloud(i)%periodic = 0
end do
Expand Down
1 change: 1 addition & 0 deletions src/pre_process/m_mpi_proxy.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ contains
call MPI_BCAST(particle_cloud(i)%moving_ibm, 1, MPI_INTEGER, 0, MPI_COMM_WORLD, ierr)
call MPI_BCAST(particle_cloud(i)%seed, 1, MPI_INTEGER, 0, MPI_COMM_WORLD, ierr)
call MPI_BCAST(particle_cloud(i)%cloud_geometry, 1, MPI_INTEGER, 0, MPI_COMM_WORLD, ierr)
call MPI_BCAST(particle_cloud(i)%shell_axis, 1, MPI_INTEGER, 0, MPI_COMM_WORLD, ierr)
call MPI_BCAST(particle_cloud(i)%packing_method, 1, MPI_INTEGER, 0, MPI_COMM_WORLD, ierr)
call MPI_BCAST(particle_cloud(i)%periodic, 1, MPI_INTEGER, 0, MPI_COMM_WORLD, ierr)
end do
Expand Down
3 changes: 2 additions & 1 deletion src/simulation/m_mpi_proxy.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,10 @@ contains
#:endfor
end do

! manual: cfl_dt (runtime-computed logical), bc_io (BC-file existence)
! manual: cfl_dt (runtime-computed logical), bc_io (BC-file existence), periodic_bc (from global BCs)
call MPI_BCAST(cfl_dt, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)
call MPI_BCAST(bc_io, 1, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)
call MPI_BCAST(periodic_bc, 3, MPI_LOGICAL, 0, MPI_COMM_WORLD, ierr)

! manual: shear_stress, bulk_stress (derived from Re_size post-init on all ranks),
! bodyForces (derived from bf_x/y/z)
Expand Down
Loading