Repository navigation
Damp hyper-cleaning psi with the current-stage value - #1987
Closed
sbryngelson wants to merge 3 commits into
Closed
sbryngelson wants to merge 3 commits into
sbryngelson wants to merge 3 commits into
Conversation
The psi damping term in s_compute_rhs read q_prim_vf(psi), the time stepper's primitive array. That array is only refreshed at the end of s_compute_rhs, and only when run_time_info, probe_wrt, ib or bubbles_lagrange is set, so the damping used the previous stage's psi or, with none of those flags, a never-written array. Toggling run_time_info changed the solution. Use q_prim_qp%vf(psi), which aliases the current-stage conservative psi. run_time_info = T and F now give bit-identical output on a shrunk 2D_orszag_tang_hyper_cleaning case. Regenerated golden for B4DC99F9 (2D -> MHD -> hyper_cleaning); max abs deviation 3.9e-4.
Member
Author
|
Closing this for now to bring the number of open PRs from me down to four, so the ones that stay open get real review attention rather than being lost in a queue of 35. No work is lost and nothing needs re-doing. The branch I intend to reopen these in small batches as the open slots free up. Apologies for the notification noise. Opened and closed with Claude Code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The psi damping term in s_compute_rhs read q_prim_vf(psi), the time
stepper's primitive array. That array is only refreshed at the end of
s_compute_rhs, and only when run_time_info, probe_wrt, ib or
bubbles_lagrange is set, so the damping used the previous stage's psi
or, with none of those flags, a never-written array. Toggling
run_time_info changed the solution.
Use q_prim_qp%vf(psi), which aliases the current-stage conservative psi.
run_time_info = T and F now give bit-identical output on a shrunk
2D_orszag_tang_hyper_cleaning case.
Regenerated golden for B4DC99F9 (2D -> MHD -> hyper_cleaning); max
abs deviation 3.9e-4.