Repository navigation
Fail fast on Flux MPI launches outside an allocation - #1972
Draft
sbryngelson wants to merge 3 commits into
Draft
sbryngelson wants to merge 3 commits into
sbryngelson wants to merge 3 commits into
Conversation
sbryngelson
force-pushed
the
fix-flux-test-login
branch
from
October 10, 2026 16:27
afbac3c to
274e7e9
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1967
On Flux systems, MPI launches outside an allocation (login node) submit a separate pbatch job per launch (default 12 h), so
./mfc.sh testqueues one job per case and appears to hang. The templates now checkFLUX_ENCLOSING_ID(set insideflux alloc/flux batch, unset on the login node) and stop with a clear message:toolchain/templates/include/helpers.mako: newrequire_flux_allocationhelper.tuo.mako: check for interactive MPI runs.default.mako: same check when the selected launcher issrunandfluxexists (on Tuolumnesrunis the Flux wrapper;mfc.sh testuses the default template, which is what produced the pbatch jobs in the issue).Testing
./mfc.sh test -j 4 --no-gpu --only Cylinderlaunched pbatch jobs (named1) via the fluxsrunwrapper (cancelled/failed immediately).flux jobsshows no pending/running jobs.flux batchon pdebug:./mfc.sh test -j 4 --no-gpu --only 6ED50013passes../mfc.sh test --no-mpi --no-gpu -j 4 --only 6ED50013passes (unaffected)../mfc.sh formatand./mfc.sh precheckpass.Not verified:
mfc.sh run -c tuointeractive path directly (same helper), batch engine, non-Flux systems. Withmfc.sh testeach selected case reports the failure rather than aborting on the first (the harness's existing early-abort applies after 20 cases). Interactiverunfails fast rather than only warning.Contribution Policy
All contributions are expected to demonstrate:
If these expectations are not met, we would prefer to implement the changes ourselves rather than spend time reviewing low-effort submissions.