Skip to content

Use the ghost-cell spacing for the z one-sided viscous gradient #2067

Open

Description

@sbryngelson

s_compute_fd_gradient's one-sided z derivative at idwbuff(3)%beg
divided by z_cc(beg + 2) - z_cc(is3_viscous%beg). is3_viscous%beg is
idwbuff(3)%beg + 1 there, so the denominator spanned one cell instead
of two and the outermost ghost gradient was doubled on a uniform grid.

Divide by z_cc(beg + 2) - z_cc(beg), matching the x and y stencils.

The 27 3D Viscous tests pass against the existing goldens.


A fix for this is already written. The pull request was closed only to reduce the number of simultaneously open PRs from this author, not because the work was rejected or found incorrect.

Tracked with the pr-to-do label so the whole set is discoverable together.

Filed with Claude Code.

Activity

  1. added
    pr-to-doFix already written in a closed PR; reopen when review capacity allows
    on Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    pr-to-doFix already written in a closed PR; reopen when review capacity allows

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions