Repository navigation
Conversation
Re-reading the block at the event position could return air. Use the block carried by PlayerPlacedBlockEvent instead. Fixes LiteLDev#402.
LeviLamina reflection headers now use std::to_underlying, so define _HAS_CXX23 for the C++20 build. ScriptBlockGlobalEventListener also needs the complete ScriptBlockBreakingEventListener type.
_AMC64_ was not referenced anywhere; _AMD64_ is the predefined MSVC/clang-cl macro.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
afterPlaceBlocknow builds the script block fromPlayerPlacedBlockEvent::placedBlock()instead of re-reading the block atpos(), which could resolve to air.Why
Closes #402. Listeners were always seeing
minecraft:air.Verification
Real client on BDS 1.26.51 / LeviLamina 26.51.7, flat world, placed grass blocks and jungle planks:
Before the change the same listener logged
minecraft:air.Additional build fixes
_HAS_CXX23for the C++20 build: LeviLamina 26.51.7 reflection headers usestd::to_underlying.ScriptBlockBreakingEventListener.hwhereScriptBlockGlobalEventListenerdestroys aunique_ptrto it, to provide the complete type.