Skip to content

Fix shell formatting validation - #55

Merged
david-kariuki merged 1 commit into
mainfrom
develop
Oct 22, 2026
Merged

david-kariuki merged 1 commit into
mainfrom
develop

Conversation

@david-kariuki

Copy link
Copy Markdown
Member

Summary

Aligns the existing shell sources with the formatting rules introduced by the CI workflow and cleans up an accidental duplicate test helper.

This fixes the Shell Formatting CI failure without changing bootstrap behaviour.

Changes

  • quote associative-array keys in config/defaults.sh
  • preserve hyphenated distro IDs such as:
    • opensuse-leap
    • opensuse-tumbleweed
  • remove the duplicate lib/testlib.sh
  • retain tests/testlib.sh as the canonical test harness
  • normalize tracked shell files with shfmt
  • add missing final newlines across shell sources

Validation

The following checks pass locally:

for shell_file in "${shell_files[@]}"; do
  bash -n "$shell_file"
done

@david-kariuki david-kariuki self-assigned this Oct 22, 2026
@david-kariuki david-kariuki added bug Something isn't working enhancement New feature or request labels Oct 22, 2026

@david-kariuki david-kariuki left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-kariuki
david-kariuki merged commit 8bf63ab into main Oct 22, 2026
3 of 4 checks passed
@david-kariuki
david-kariuki deleted the develop branch November 8, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant