Remove disconnected drawing board participants - #307
Merged
auvipy merged 2 commits intoOct 4, 2026
Merged
Conversation
auvipy
self-requested a review
October 3, 2026 03:35
auvipy
requested changes
Oct 3, 2026
auvipy
left a comment
Collaborator
There was a problem hiding this comment.
please add appropriate unit tests for this change
Contributor
Author
|
Added the requested unit tests for the actual drawing-board plugin, including its connection-close callback, preservation of another participant, and repeated/unknown unregister calls. All three fail on the unchanged upstream implementation and pass with this fix. The full Linux/Python 3.12 suite passes: 127 tests. |
auvipy
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disconnected drawing-board clients remain in
board['handlers']becauseunregister_participantchecks the outer board metadata instead of the handler map. Check the handler map before removing the participant.Fixes #306.
Added tests that import the actual example and instantiate its plugin and handlers on an isolated CherryPy bus. They cover removal without affecting another participant, the connection-close callback, and harmless repeated or unknown unregister calls. No server or monitor thread is started. Mako is included in the test requirements because the example imports it.
Validation: all three regression tests fail against the unchanged upstream implementation and pass with the fix. The complete suite passes on Linux/Python 3.12: 127 passed. The three focused tests also pass on Windows/Python 3.13.