Skip to content

Fix FileWatcher permissions issues - #8117

Open
labkey-alan wants to merge 10 commits into
release26.7-SNAPSHOTfrom
26.7_fb_filewatcher_perms
Open

Fix FileWatcher permissions issues#8117
labkey-alan wants to merge 10 commits into
release26.7-SNAPSHOTfrom
26.7_fb_filewatcher_perms

Conversation

@labkey-alan

@labkey-alan labkey-alan commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Rationale

This PR (and related) fix Issues 1524 and 1626

Related Pull Requests

Changes

  • Require the Trusted Analyst or Platform Developer permission to add, change, or clear a file watcher's Parameter Function; folder admins can still edit other trigger settings when the function is left unchanged
  • Hide the Parameter Function in the pipeline trigger wizard from users without that permission, and keep an existing function when the task changes
  • Stop pre-filling the Parameter Function from URL parameters when creating a trigger
  • Restrict trigger configuration updates to the current folder and report update errors instead of dropping them (GH Issue 1626)
  • Reject trigger configurations that aren't valid JSON, for all users
  • Reject bulk loading of trigger configurations
  • Start and stop trigger listeners only after the change is committed
  • Lint CreatePipelineTrigger.tsx
  • Add integration tests for these cases

Tasks

  • Claude Code Review
  • Manual Testing
  • Test Automation
  • Verify Fix

@labkey-alan
Add JUnit tests for Issues 1524 and 1626
176cda4 
- Tests fail, as intended
@labkey-alan
TriggerConfigurationsTable::updateRows - Actually pass oldRow when up…
886e791 
…dating, properly handle validationErrors
@labkey-alan
TriggerConfigurationsTable::updateRows - throw when errors.hasErrors(…
f63bcd9 
…) is true
@labkey-alan
TriggerConfigurationsTable: validate configuration during _insert and…
c81934e 
… _update

- Only allow valid JSON to be inserted
- Only allow trusted analysts to alter Parameter Function
@labkey-alan
PipelineController: Don't prefill parameter function from URL params
31d2fe9
@labkey-alan
createPipelineTrigger.jsp - Hide Parameter Function for anyone that i…
6f49bee 
…sn't a trusted analyst
@labkey-alan
CreatePipelineTrigger.tsx - Lint file
c8bb5cf
@labkey-alan
PipelineController: Fix testCreateTriggerIgnoresParameterFunctionFromUrl
39b9fe3
@labkey-alan
TriggerConfigurationsTable: improve error message
cc14233
@labkey-alan
TriggerConfigurationsTable: start/stop configs as commit tasks
de0248d 
Prevents starting/stopping tasks when transactions are rolled back
@labkey-alan labkey-alan self-assigned this Sep 30, 2026
@labkey-alan labkey-alan mentioned this pull request Sep 30, 2026
Open
2 of 4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@labkey-klum labkey-klum Awaiting requested review from labkey-klum

At least 1 approving review is required to merge this pull request.

Assignees

@labkey-alan labkey-alan

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@labkey-alan