Skip to content

Issue 1603: Improve performance when creating a job with thousands of samples #8116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
labkey-susanh wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Issue 1603: Improve performance when creating a job with thousands of samples #8116

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
06e787d
Add optional includeEntities property to jobCreationForm so we can av…
labkey-susanh Sep 29, 2026
e7c5c11
Add some streams for better memory usage
labkey-susanh Sep 29, 2026
6e0f6a0
Merge remote-tracking branch 'origin/develop' into fb_jobCreationPerf
labkey-susanh Sep 30, 2026
84c5edc
Use an uncached stream to avoid creating the collection
labkey-susanh Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions api/src/org/labkey/api/workflow/Job.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
package org.labkey.api.workflow;

import com.fasterxml.jackson.annotation.JsonIgnore;
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import org.jetbrains.annotations.NotNull;
import org.json.JSONObject;
Expand Down Expand Up @@ -45,6 +46,7 @@
import java.util.Map;
import java.util.Objects;
import java.util.stream.Collectors;
import java.util.stream.Stream;

public abstract class Job extends CreatedModified implements Identifiable
{
Expand Down Expand Up @@ -319,19 +321,29 @@ public void setAttachments(List<AttachmentFile> attachments)
_attachments = attachments;
}

@JsonIgnore
public abstract List<WorkEntity> getEntities();

// Serialize only preloaded entities; getEntities() lazily queries them
@JsonProperty("entities") @JsonInclude(JsonInclude.Include.NON_NULL)
public List<WorkEntity> getLoadedEntities()
{
return _entities;
}

@JsonIgnore
public abstract @NotNull List<? extends ExpMaterial> getSamples();

// Backed by an open ResultSet; callers must close it
@JsonIgnore
public abstract @NotNull List<String> getSampleNames();
public abstract @NotNull Stream<String> getSampleNames();

@JsonIgnore
public abstract @NotNull List<? extends ExpData> getSources();

// Backed by an open ResultSet; callers must close it
@JsonIgnore
public abstract @NotNull List<String> getSourceNames();
public abstract @NotNull Stream<String> getSourceNames();

public void setEntities(List<WorkEntity> entities)
{
Expand Down
Loading