Expect 104 kinship rows, old script counted invented parents - #304
Merged
Merged
Conversation
labkey-danield
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The expected kinship row count drops from 136 to 104 with the new populateKinship.r due to three animals in the test sample data have only one fake parent (999915, 999916, or 999917 - these IDs are not in the pedigree, not in study.demographic) on file. The old script used kinship2, which makes up a fake second parent in that case. It tried to remove those fakes by name, but that check only worked when animal ids are text, and the test uses numbers so three made up animals ended up in ehr.kinship. The new script does not make up parents, so their 32 rows are gone.
Related Pull Requests
Changes