Repository navigation
feat(action): fail-on-scan-error input; never report a stale SBOM - #139
Merged
Merged
Conversation
A scan that exits 1 (a missing directory, a parse error, an unreadable model file such as a git-LFS pointer stub) used to end the Action job green with nothing said. It now adds a warning annotation, and fails the job with exit 1 when `fail-on-scan-error: true`. The default stays false and becomes true at the next major release. The Action now deletes its output file and the matching VEX files before scanning, so a file left by an earlier step or committed to the repo is never commented on or uploaded as this run's result. Exit precedence is 2, then 1, then 3; the upload still runs first.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fail-on-scan-errorinput (defaultfalse). Whenaisbom scanexits 1 (a directory that doesn't exist, a file it couldn't parse, an unreadable model file such as a git-LFS pointer stub), the job used to pass with nothing said. It now adds a warning annotation, and fails the job with exit 1 when the input istrue. Any exit other than 0 and 2 counts. The default becomestrueat the next major release.*.openvex.json/*.vex.cdx.jsonbefore scanning. A scan that writes nothing produces no PR comment and no upload. Nothing else in the workspace is touched.action.ymlthat passes ten args keeps today's behaviour ($11defaults tofalse).Tests
tests/test_action_entrypoint.py: theaisbomstub now writes--outputonly when the test says the scan produced it, so a stale file and a fresh one are distinct. 20 new tests cover stale-file removal (SBOM, VEX, custom paths, unrelated files kept) and the new input (default warning, opt-in failure, exact-trueonly, crash exits, precedence against exit 2 and 3).shellcheck action/entrypoint.shclean..ptand.safetensorsLFS pointer stubs exits 1 and still writes an SBOM.Docs:
action.yml,action/README_ACTION.md(input row, quick-start step, troubleshooting entry), CHANGELOG.