Repository navigation
Fix SquashFS test fixtures when mksquashfs lacks xattr support - #84
Merged
Olof-Lagerkvist merged 1 commit intoOct 11, 2026
Merged
Olof-Lagerkvist merged 1 commit into
Olof-Lagerkvist merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When mksquashfs is installed but was built without xattr support, SquashFixtures still requests
-xattrs-addfor its fourth image. The resulting error aborts the shared setup, so unrelated SquashFS reader tests fail and repeatedly rebuild the other three images. This matches the reported FreeBSD failure.The setup now caches generated image paths individually. The three
-no-xattrsfixtures are still built fresh. Only when the optional xattr image returns exit code 1 with the exact unsupported-xattrs diagnostic does it use the existing embedded xattr fixture, discarding any partial output. The xattr reader test continues to run; other tool errors remain failures.Validation performed on Linux:
FreeBSD execution has not been performed here. No library code or embedded images are changed.