Repository navigation
Conversation
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESA ECal/HCal dev from Oct 2026.
CHARGE_TIMESCANfailing on the Si ROC by settingCALIB_2V5andCHOICE_CINJonly for the SiPM ROC incharge_timescan.cxx(b81c8a3)-sscript ran out with no terminal attached; end of input now leaves the menus cleanly insrc/pflib/menu/Menu.cc(a485902)TOA_SCANandTOT_SCANfailing on the Si ROC by settingCHOICE_CINJonly for the SiPM ROC (cd22934)PHASE_WORD_ALIGNbroadcasts link resets, which made every ECON-D re-snapshot and lose word lock. It now setsALIGNER.GLOBAL_SNAPSHOT_EN = 0after a successful word align (cb8cf3d)BWOptoLink::reset_link, since pfinit's buffer bypass only completes with them; bbd63c8 removed them and is reverted by b8ec2f4ROC::readPageandwritePagecorrupting registers on an I2C retry: the R3 address auto-increments, so each attempt now re-points to the start of its chunk, and the retry counter actually counts (470f0e6)config/calib/<target>/<date>.yamlper target with a shared base file, per-ROC settings, masks, the FC calib delay and the expected pedestal. Acalib:line in the target yaml names the active set,ROC APPLY_CALIBloads it, andana/calib/make_calib.pybuilds it from the settings files the tasks write (1cd8ef8)TOA_SCANandTOT_SCANsettings, and masks on high-pedestal channels (2b64c6e)TASKS CHECK_PEDESTAL, which compares a pedestal run with the calibration set's expected pedestal per channel (735b7e9)Tested at ESA on CaloBittware: ECal L1 to L3 alignment (all eRx at bx 20) and pedestals; L2 and L3 leveled to about 200 ADC with a channel spread of about 5 ADC and no frozen channels. HCal alignment and pedestal on
datadev_2.