Repository navigation
fix: preserve resource aliases in render checkpoints - #7
Merged
Merged
Conversation
LBEILC
marked this pull request as ready for review
October 21, 2026 06:56
Owner
|
Merged, thank you! The reproduction and the clear limits in the description made this easy to review. I checked it locally on Windows 11 as well: the new alias tests pass, using junctions (the file-symlink case is skipped without Developer Mode, as the test intends), and so do the existing server, resume and resources tests. CI passed on all three platforms. One small observation, not a blocker: on Windows, if This will ship in 0.3.14, with credit in the release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Interrupted renders can resume with changed asset content after a symlink is retargeted: only the old canonical target is recorded, so unchanged target files pass both input checks while different segments load different content. Reproduced with the real resource server and checkpoint store, including project-root and directory aliases.
Changes
Record logical resource paths alongside resolved files using the same content digest, preserve project-root aliases through capture setup, and retain canonical confinement checks. Cover directory indexes and ranged media without hashing aliases twice; same-content retargets remain reusable.
Protection applies to newly recorded checkpoints. Historical manifests without alias mappings cannot be repaired retrospectively. This does not claim an atomic filesystem snapshot or fix existing in-place large-file cache/hash-versus-stream races.
Validation
The published tree matches the locally tested tree exactly: f5d74331682d93f1103e7cb3f525cb78fee4450a. Separate from the existing config-lock draft.
AI disclosure
Implemented and independently reviewed with an OpenAI coding assistant. Reproductions and reported checks were actually run; browser and cross-platform limitations are explicit.