Repository navigation
👷 [ci] unify platform builds and replace Vulkan SDK installer - #33
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate Windows clang-cl, Windows MSVC and macOS ARM64 clang into one build matrix. Install the full Vulkan SDK through jakoch/install-vulkan-sdk-action v1.7.0, and share dependency caching and build steps. Keep resolved tool versions in cache keys and remove the redundant macOS SDK component check.
Import platform-specific XMake configuration from .github/configs/*.conf. Build with plain xmake, using default output and parallelism. Test targets are compiled but not run.
Fix MSVC test-target compilation: rename the GUI contract test namespace alias to pocketjs to avoid colliding with the imported global pocket namespace, and move platform conditionals outside GoogleTest instantiation macros in five renderer test files.
Use explicit out-of-line bodies for RigWorld and JoltRigWorld destructors to avoid MSVC duplicate symbols from imported defaulted destructor definitions; member cleanup remains automatic.
Validation: actionlint and whitespace checks pass. All three matrix entries (macOS ARM64 clang, Windows clang-cl, Windows MSVC) passed at a51f485: https://github.com/L-Sun/HitagiEngine/actions/runs/40093997720 . Libraries, examples and test targets were built; tests were not executed.