Repository navigation
docs(governance): propose per-stage approvals for BDD, SDD, TDD - #239
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
…out blanket adoption
|
@codex review Please perform a read-only, evidence-based review of this draft documentation PR (#239) and its canonical issue #238 in Review priorities:
Do not write/edit implementation or spec files; do not edit protected policy/workflows/roles, open another issue/PR, merge, deploy, approve on behalf of Ky, run provider calls, or represent this review as a Kiro spec. Return findings or exact blocker only. Respect current spec-first role constraints. This one review request is not authority for future phase approvals. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex Investigate the CURRENT enforcement gaps for the existing stage-gated BDD → SDD/requirements → TDD/RED → implementation → independent verification proposal. Read-only investigation and report only. No file changes, commits, branch, new issue/PR, spec authoring, environment setup, expenses, gate bypass, merge, deployment, or changing this PR. Canonical home: KyPython/ai-governance issue #238; existing draft documentation PR #239 (this thread). Related decision-ownership issue #225 is a separate scope. Requested by Ky on 2026-11-01; this GitHub comment was posted by GPT-6 using the connected owner token, NOT by Ky directly, Kiro, or Codex. Verified findings to independently check at current HEAD, not blindly trust: (1) ai-governance/main has the spec/role policy and test suite; (2) KyLamportLogic/buildlogic-governance/.github/workflows/ai-governance.yml on main is pinned to Deliverable on this existing PR conversation, without a write to repo: a compact independently sourced PASS / FAIL / UNKNOWN matrix for each actual enforcement boundary; the 3 most critical reproducible adversarial negatives (identity forgery, stale/missing transition authorization, vacuous/misleading trace), exact repo paths and current SHAs, command/output evidence if you can run existing tests in an isolated read-only/scratch checkout, and an incremental spec-author handoff for issue #238 (requirements/design/tasks/acceptance tests), with owner approvals and protected mutation gates explicitly retained. Hard stop: Current policy permits Kiro (or separately authenticated human owner override) to author/merge the governing spec, before Codex implementation. PR #239 is a draft proposal only, not merged or authorized as an implementation spec; #219 defines a limited Kiro-unavailable fallback and prohibits Codex identity substitution. Do not treat this message, a green CI check, a @codex mention, or connected GitHub owner tokens as approval to write code or spec. No automated dispatch to implementation. If no permitted read-only execution route exists, report exact blocker here. Existing canonical addendum updated 2026-11-01 — GPT-6 / AI HANDOFF, NOT AN OWNER STAGE APPROVAL. @codex Continue from the existing #238 work record, not a new tracker or a duplicate task: #238 (comment) . Read the appended section “2026-11-01 — security and executable-pilot addendum” before any proposed changes. It contains the substantive gaps missing from the earlier documentation-only review: authenticated stage-specific non-agent-forgeable approvals, read-only isolated agent execution vs post-PR CI, independent constrained publisher, trust boundaries and OIDC/signing limitations, immutable SHA drift remediation without floating tags, six adversarial V1–V6 controls including the authorized positive control, structured expected RED assertions vs harness failures, mutation/negative-control adequacy only after implementation, and existing LamportLogic pre-mutation gate reuse. The previous “no major issues” review of docs is NOT an implementation security pass. Execution order: verify live source/branches/PRs and competing Codex/Kiro work; prepare the spec-writer handoff and reviewable evidence first under the canonical issue. Current PR #239 is documentation-only and unmerged. Do not write/edit protected policies, stage specs, tests, production code, workflows or roles; do not create another issue/PR, bypass the current spec-first gate, assume Kiro credits, use Ky's token as verified identity, deploy or merge. A separate owner-approved merged spec and per-path authorization are prerequisites to any implementation. If Codex cannot complete the source-grounded preparation without writing, report the exact blocker. Tell Ky exactly what human/spec-author approval unblocks the next stage; do not silently self-approve. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the documentation-only staged approval and selective BDD rollout proposal.
No open issues 🎉
What changed in this PR
Adds a documentation-only proposal for staged human approvals and selective Cucumber/Gherkin adoption across repositories, supporting issue #238. It preserves existing spec-first governance and explicitly states that G0–G6 are not yet enforced.
Changes:
- Defines proposed G0–G6 approval checkpoints, revision-bound evidence, and fail-closed enforcement requirements.
- Establishes criteria for selecting one justified pilot, choosing compatible tooling, and verifying real behavioral outcomes.
- Documents authorization blockers, rollout boundaries, and exclusions without changing code, dependencies, or CI.
| File | Description |
|---|---|
docs/operations/cucumber-bdd-rollout.md |
Proposes staged approvals and a selective, spec-first BDD rollout guide. |
Review effort: Balanced
Relates to #238
Scope
docs/operations/.Status and governance
AGENTS.governance.md,roles.yml, the reusable verdict workflow or agent dispatch hooks; those files have not been changed.Implementation authorization blocker
Testing
Failure risks