Repository navigation
Dev application: By the greatest Kevin - #597
Kevinli7673 wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughAdds a responsive poster-style Kevin Li hero page with decorative artwork, text, and a grain overlay. The cloud reveals LinkedIn, Resume, and GitHub links on hover or keyboard focus. The page includes motion effects and reduced-motion handling. Priority: ⬇️ Low Merge Risk: 🟡 Moderate · up to Touch visitors may be unable to open the page’s profile links, and the links are too small when available. Fix the touch reveal and target sizes before merging. 🚥 Pre-merge checks | ✅ 6 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (6 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
apps/blade/src/app/KevinLi/components/hero.module.cssESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. apps/blade/src/app/KevinLi/components/hero.tsxESLint skipped: the matched ESLint configuration already failed (missing-dependency). apps/blade/src/app/KevinLi/page.tsxESLint skipped: the matched ESLint configuration already failed (missing-dependency). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Note
Quiet mode is enabled, so only the most important comments were posted inline. Other review comments are grouped below.
🟡 Other comments (2)
apps/blade/src/app/KevinLi/components/hero.tsx-151-152 (1)
151-152: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winGive each profile link a 24px minimum height.
At 390px, each unpadded link target is at most 17.1px high, and adjacent target centers are only 21.9px apart. The WCAG 2.2 spacing exception does not apply.
🐛 Suggested fix
- className={`${jacquesShadow.className} ${styles.link} pointer-events-none rounded-sm leading-none focus-visible:outline-2 focus-visible:outline-offset-4 focus-visible:outline-[#214e92] group-hover:pointer-events-auto group-has-[:focus-visible]:pointer-events-auto`} + className={`${jacquesShadow.className} ${styles.link} pointer-events-none rounded-sm min-h-[24px] flex items-center leading-none focus-visible:outline-2 focus-visible:outline-offset-4 focus-visible:outline-[#214e92] group-hover:pointer-events-auto group-has-[:focus-visible]:pointer-events-auto`}apps/blade/src/app/KevinLi/components/hero.tsx-130-155 (1)
130-155: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winAdd an explicit tap-controlled reveal for the cloud links.
On supported iOS Safari, a tap reaches the non-clickable cloud
<div>and does not trigger hover. The nav stays hidden and its links stay pointer-disabled, so touch users cannot open these links from the hero.
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository: KnightHacks/forge/.coderabbit.yml
- Review profile: QUIET
- Plan: Advanced
- Run ID:
462d66be-72df-4b5a-ae9b-5b8c77a25771
⛔ Files ignored due to path filters (6)
apps/blade/public/kevin-li/bench.pngis excluded by!**/*.pngapps/blade/public/kevin-li/cloud-figma.pngis excluded by!**/*.pngapps/blade/public/kevin-li/leaves-left.pngis excluded by!**/*.pngapps/blade/public/kevin-li/leaves-right.pngis excluded by!**/*.pngapps/blade/public/kevin-li/resume.pdfis excluded by!**/*.pdfapps/blade/public/kevin-li/sky-clouds-straight.pngis excluded by!**/*.png
📒 Files selected for processing (3)
apps/blade/src/app/KevinLi/components/hero.module.cssapps/blade/src/app/KevinLi/components/hero.tsxapps/blade/src/app/KevinLi/page.tsx
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
What changed
/KevinLipage to Blade with a hero recomposed from my Figma poster (bench, leaves, sky strip, drifting cloud)./kevin-li/resume.pdf.Scope
Only
apps/blade/src/app/KevinLi/andapps/blade/public/kevin-li/. No shared packages touched.Checks
pnpm --filter=@forge/blade typecheckpasses