Skip to content

fix(portable): tell packagers to drop filee.portable, make the error readable - #1643

Merged
KnifeLemon merged 1 commit into
mainfrom
fix/portable-packagers-1590
Nov 17, 2026
Merged

KnifeLemon merged 1 commit into
mainfrom
fix/portable-packagers-1590

Conversation

@KnifeLemon

Copy link
Copy Markdown
Owner

What does this change?

Both parts of #1590:

  1. A line for packagers in installer/linux/INSTALL.txt: delete filee.portable (and any data folder) from an installed copy, e.g. after cp -a into /opt/filee, as install.sh does (it skips both when copying and removes the marker). With the marker, Filee keeps its data in data beside the executable, and where users can't write there it stops with an error. docs/PORTABLE.md says the same next to "Installer packages keep using the normal user profile".
  2. The unwritable-folder error is readable and leaves a trace:
    • PortableStartupFailure's Avalonia window (Linux/macOS; Windows uses a native message box) started without Filee's font collections, so text the system's default font lacks (Chinese under language: auto) came out as boxes. It now registers FileeFontCollection and SystemUiFontCollection like the app and sets the UI language's font chain (SoftPalette.FontFamilyFor) and reading direction (Arabic right to left).
    • The localized message already went to stderr; stderr now also gets an English line with the folder, the underlying error (e.g. permission denied) and that deleting filee.portable uses the normal profile. Nothing is written to a log elsewhere on purpose: a portable copy must not touch the user profile, and its own log is in the folder that failed.

No UI string changed (the stderr line is a diagnostic, English like the CLI's).

Fixes #1590 (the "installed by a package manager" update state mentioned there as minor is not part of this)

Type of change

  • Bug fix
  • Documentation

How was it tested?

  • dotnet format --verify-no-changes --severity warn on the changed files (Filee.App, Filee.App.Tests)
  • dotnet test tests/Filee.App.Tests --filter "PortableStartupFailure|PortableCleanup": new PortableStartupFailureTests (font chain and direction for zh-CN, ar, en; the stderr line names folder, cause and marker)

🤖 Generated with Claude Code

…readable

A distribution package that copies the Linux archive as it is (cp -a into
/opt/filee, as the AUR filee-bin package did) ships the filee.portable
marker, so Filee looks for its data in /opt/filee/data, can't write there
and stops. INSTALL.txt now has a line for packagers: delete filee.portable
and any data folder from an installed copy, as install.sh does.
docs/PORTABLE.md says the same.

The window shown for an unwritable portable data folder opened before
Filee's fonts were loaded, so on Linux Chinese and other scripts the
system's default font lacks were drawn as boxes. It now loads Filee's font
collections and uses the UI language's font chain and reading direction.
Since the log lives in that same folder, stderr gets one more English line
with the folder, the cause and the marker to delete.

Fixes #1590

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the bug Something isn't working label Nov 17, 2026
@KnifeLemon
KnifeLemon merged commit e80de86 into main Nov 17, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

INSTALL.txt for packagers: delete filee.portable (and make an unwritable portable data dir explain itself)

1 participant