Repository navigation
fix(portable): tell packagers to drop filee.portable, make the error readable - #1643
Merged
Merged
Conversation
…readable A distribution package that copies the Linux archive as it is (cp -a into /opt/filee, as the AUR filee-bin package did) ships the filee.portable marker, so Filee looks for its data in /opt/filee/data, can't write there and stops. INSTALL.txt now has a line for packagers: delete filee.portable and any data folder from an installed copy, as install.sh does. docs/PORTABLE.md says the same. The window shown for an unwritable portable data folder opened before Filee's fonts were loaded, so on Linux Chinese and other scripts the system's default font lacks were drawn as boxes. It now loads Filee's font collections and uses the UI language's font chain and reading direction. Since the log lives in that same folder, stderr gets one more English line with the folder, the cause and the marker to delete. Fixes #1590 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Both parts of #1590:
installer/linux/INSTALL.txt: deletefilee.portable(and anydatafolder) from an installed copy, e.g. aftercp -ainto/opt/filee, asinstall.shdoes (it skips both when copying and removes the marker). With the marker, Filee keeps its data indatabeside the executable, and where users can't write there it stops with an error.docs/PORTABLE.mdsays the same next to "Installer packages keep using the normal user profile".PortableStartupFailure's Avalonia window (Linux/macOS; Windows uses a native message box) started without Filee's font collections, so text the system's default font lacks (Chinese underlanguage: auto) came out as boxes. It now registersFileeFontCollectionandSystemUiFontCollectionlike the app and sets the UI language's font chain (SoftPalette.FontFamilyFor) and reading direction (Arabic right to left).filee.portableuses the normal profile. Nothing is written to a log elsewhere on purpose: a portable copy must not touch the user profile, and its own log is in the folder that failed.No UI string changed (the stderr line is a diagnostic, English like the CLI's).
Fixes #1590 (the "installed by a package manager" update state mentioned there as minor is not part of this)
Type of change
How was it tested?
dotnet format --verify-no-changes --severity warnon the changed files (Filee.App, Filee.App.Tests)dotnet test tests/Filee.App.Tests --filter "PortableStartupFailure|PortableCleanup": newPortableStartupFailureTests(font chain and direction for zh-CN, ar, en; the stderr line names folder, cause and marker)🤖 Generated with Claude Code