Skip to content

Drop all deprecated components - #73

Merged
Kicer86 merged 4 commits into
masterfrom
deprecated_drop
Apr 26, 2026
Merged

Kicer86 merged 4 commits into
masterfrom
deprecated_drop

Conversation

@Kicer86

@Kicer86 Kicer86 commented Apr 26, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes deprecated connection components and deprecated GitHub API surface, consolidating the codebase around the factory-based connection creation APIs and unique-ownership semantics.

Changes:

  • Removed deprecated backend *::Connection headers/APIs and associated warning-suppression pragmas.
  • Updated cpp_restapi::GitHub::Request to take/store std::unique_ptr<IConnection> and removed the deprecated typo’d method.
  • Inlined backend create*Connection() implementations into backend connection.cpp files and updated tests to use non-deprecated backend tags/factories.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/github_request_tests.cpp Switch typed tests to backend “tag” types and pass connections via std::unique_ptr into GitHub::Request.
tests/connection_tests.cpp Switch typed tests to backend “tag” types, centralize backend construction, and replace Qt-backend type-trait with a tag constant.
src/services/github/request.cpp Update Request ctor to accept std::unique_ptr<IConnection> and remove deprecated getAuntenticatedUser() implementation.
src/qt_backend/create_connection.cpp Deleted; factory implementation moved elsewhere.
src/qt_backend/connection.cpp Replaces deprecated public Qt connection type with an internal implementation and defines createQtConnection() here.
src/qt_backend/CMakeLists.txt Stop compiling removed create_connection.cpp.
src/curl_backend/create_connection.cpp Deleted; factory implementation moved elsewhere.
src/curl_backend/connection.cpp Replaces deprecated public Curl connection type with an internal implementation and defines createCurlConnection() here.
src/curl_backend/CMakeLists.txt Stop compiling removed create_connection.cpp.
src/cpp-httplib_backend/create_connection.cpp Deleted; factory implementation moved elsewhere.
src/cpp-httplib_backend/connection.cpp Replaces deprecated public cpp-httplib connection type with an internal implementation and defines createCppHttplibConnection() here.
src/cpp-httplib_backend/CMakeLists.txt Stop compiling removed create_connection.cpp.
include/cpp_restapi/qt_connection.hpp Deleted deprecated Qt connection header.
include/cpp_restapi/isse_connection.hpp Update docs to reference IConnection::fetch() (but has a formatting nit).
include/cpp_restapi/github/request.hpp Update Request API to std::unique_ptr<IConnection> and remove deprecated typo’d method declaration.
include/cpp_restapi/github/connection_builder.hpp Remove deprecated build<CT>() overload; keep factory-based build() returning std::unique_ptr.
include/cpp_restapi/curl_connection.hpp Deleted deprecated Curl connection header.
include/cpp_restapi/cpp-httplib_connection.hpp Deleted deprecated cpp-httplib connection header.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread include/cpp_restapi/isse_connection.hpp Outdated
*
* Provides streaming subscription to an SSE endpoint.
* Unlike IConnection::get() which returns a complete response,
* Unlike IConnection::fetch() which returns a complete response,

Copilot AI Apr 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Doxygen comment indentation is inconsistent on this line (missing leading space before *), which breaks the block’s alignment and can affect generated docs. Align this line with the surrounding * lines.

Suggested change
* Unlike IConnection::fetch() which returns a complete response,
* Unlike IConnection::fetch() which returns a complete response,

Copilot uses AI. Check for mistakes.
@Kicer86
Kicer86 merged commit 68d94bc into master Apr 26, 2026
16 checks passed
@Kicer86
Kicer86 deleted the deprecated_drop branch April 26, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants