Repository navigation
Drop all deprecated components - #73
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes deprecated connection components and deprecated GitHub API surface, consolidating the codebase around the factory-based connection creation APIs and unique-ownership semantics.
Changes:
- Removed deprecated backend
*::Connectionheaders/APIs and associated warning-suppression pragmas. - Updated
cpp_restapi::GitHub::Requestto take/storestd::unique_ptr<IConnection>and removed the deprecated typo’d method. - Inlined backend
create*Connection()implementations into backendconnection.cppfiles and updated tests to use non-deprecated backend tags/factories.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/github_request_tests.cpp | Switch typed tests to backend “tag” types and pass connections via std::unique_ptr into GitHub::Request. |
| tests/connection_tests.cpp | Switch typed tests to backend “tag” types, centralize backend construction, and replace Qt-backend type-trait with a tag constant. |
| src/services/github/request.cpp | Update Request ctor to accept std::unique_ptr<IConnection> and remove deprecated getAuntenticatedUser() implementation. |
| src/qt_backend/create_connection.cpp | Deleted; factory implementation moved elsewhere. |
| src/qt_backend/connection.cpp | Replaces deprecated public Qt connection type with an internal implementation and defines createQtConnection() here. |
| src/qt_backend/CMakeLists.txt | Stop compiling removed create_connection.cpp. |
| src/curl_backend/create_connection.cpp | Deleted; factory implementation moved elsewhere. |
| src/curl_backend/connection.cpp | Replaces deprecated public Curl connection type with an internal implementation and defines createCurlConnection() here. |
| src/curl_backend/CMakeLists.txt | Stop compiling removed create_connection.cpp. |
| src/cpp-httplib_backend/create_connection.cpp | Deleted; factory implementation moved elsewhere. |
| src/cpp-httplib_backend/connection.cpp | Replaces deprecated public cpp-httplib connection type with an internal implementation and defines createCppHttplibConnection() here. |
| src/cpp-httplib_backend/CMakeLists.txt | Stop compiling removed create_connection.cpp. |
| include/cpp_restapi/qt_connection.hpp | Deleted deprecated Qt connection header. |
| include/cpp_restapi/isse_connection.hpp | Update docs to reference IConnection::fetch() (but has a formatting nit). |
| include/cpp_restapi/github/request.hpp | Update Request API to std::unique_ptr<IConnection> and remove deprecated typo’d method declaration. |
| include/cpp_restapi/github/connection_builder.hpp | Remove deprecated build<CT>() overload; keep factory-based build() returning std::unique_ptr. |
| include/cpp_restapi/curl_connection.hpp | Deleted deprecated Curl connection header. |
| include/cpp_restapi/cpp-httplib_connection.hpp | Deleted deprecated cpp-httplib connection header. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| * | ||
| * Provides streaming subscription to an SSE endpoint. | ||
| * Unlike IConnection::get() which returns a complete response, | ||
| * Unlike IConnection::fetch() which returns a complete response, |
There was a problem hiding this comment.
The Doxygen comment indentation is inconsistent on this line (missing leading space before *), which breaks the block’s alignment and can affect generated docs. Align this line with the surrounding * lines.
Suggested change
| * Unlike IConnection::fetch() which returns a complete response, | |
| * Unlike IConnection::fetch() which returns a complete response, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.