Repository navigation
Merge 4.3.1 to main - #117
Merged
Merged
Conversation
PR #112 was merged with a bot docs commit as its head, which suppressed the pull_request closed event that creates the final release.
Release 4.3.0 (re-trigger)
* ab111525 * ab111525 --------- Co-authored-by: leefine02 <kfadmin@LFINE-KF10-ORCH>
There was a problem hiding this comment.
🟡 Changes recommended
The protocol swap also reverses Windows path-formatting flags, breaking transfers to Windows stores managed through SSH.
1 open issue
What changed in this PR
Merges release 4.3.1 into main, restoring SCP-first transfer attempts in the SSH certificate-store handler.
Changes:
- Attempts SCP before SFTP for uploads and downloads when
BOTHis selected. - Updates transfer logging and exception handling.
- Documents the transfer-order change in the changelog.
| File | Description |
|---|---|
| RemoteFile/RemoteHandlers/SSHHandler.cs | Reorders transfer protocols and updates error handling. |
| CHANGELOG.md | Adds the v4.3.1 transfer-order release note. |
Review effort: Balanced
| using (MemoryStream stream = new MemoryStream(certBytes)) | ||
| { | ||
| client.Upload(stream, FormatFTPPath(uploadPath, false)); | ||
| client.UploadFile(stream, FormatFTPPath(uploadPath, false)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge release-4.3 to main - Automated PR