Repository navigation
Improve error messages for ctd and viva (and more). Refactor run result handling - #504
Merged
pehrsoderman merged 5 commits intoOct 14, 2026
Merged
Conversation
…n more crash messages
gkreitz
force-pushed
the
119_improve_viva_error_message
branch
from
October 14, 2026 11:11
4baa705 to
db12487
Compare
pehrsoderman
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves several error messages. Most notable is that syntax errors in ctd and viva scripts are now reported. Several places where we reported a raw status int (i.e., what you get back from
wait) or just said "crashed", we now print a readable string like "Exit 4" or "SIGSEGV".This is done by refactoring
Execute.runto return aRunResultcontaining the runtime + status, plus some properties to easily interpret and render the status (result.exitcode == 0reads better thanos.WIFEXITED(status) and WEXITSTATUS(status) == 0). There's also a companion method to run and capture stdout/stderr.Fixes #119