Contain UDF errors and release aggregate state safely - #360
Merged
Merged
Conversation
quinnj
referenced
this pull request
Sep 30, 2026
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A registered aggregate that succeeds on one row and throws on the next can leave a freed state buffer referenced by SQLite; closing the database then aborts the reproduced child process. Scalar and aggregate exceptions also escape through their C callback boundary instead of returning a SQLite error.
Report callback and value-conversion failures through SQLite's error API. Transfer aggregate buffer ownership before fallible work, release it exactly once, and preserve the existing empty-input result. The final callback now uses SQLite's single-argument C signature.
Validation: full suites pass on Julia 1.9.4 and 1.12.7 (285 checks each, including 58 new regressions). All four isolated error/reuse/close controls exit normally under allocator scribbling. Independent ownership review and 61 additional grouped/GC/error controls passed. Another 15 checks cover both execution APIs, lazy iteration, statement rollback, explicit transactions, and recovery.
Co-authored by Codex