Preserve temporary tables when starting transactions - #357
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting a transaction can delete existing temporary tables. The shared transaction function changes
PRAGMA temp_storetoMEMORY; SQLite deletes the temporary schema when that setting changes. This also makesload!(...; temp=true)fail on a fresh connection withno such table.Remove that assignment so transactions preserve temporary objects and the connection's storage policy. Default or explicitly file-backed temporary storage now stays in effect. Applications that require memory storage can configure it before creating temporary objects.
Fixes #330.
Validation: the new regressions fail on the unchanged source (4 errors). Full suites pass on Julia 1.9.4 and 1.13.0 (245 checks each). Tests cover default/FILE/MEMORY settings, direct rollback, nested savepoint rollback, outer commit, and fresh temporary-table loading. Another 34 checks cover helper callers and file-backed connection lifetime.
Co-authored by Codex