Conversation
A security-sensitive libpq keyword set to a value this driver cannot honor is rejected with an ArgumentError that printed "key=value". For sslpassword that value is the client key passphrase, so it ended up in logs and stack traces. The error now names only the parameter, as the unrecognized-parameter error already does. Which values are rejected is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A security-sensitive libpq keyword set to a value Postgres.jl cannot honor is rejected with an
ArgumentErrorthat printedkey=value. Forsslpasswordthat value is the client key passphrase, so it ended up in error messages, logs and stack traces:The URI form (
?sslpassword=...) goes through the same check.The error now names only the parameter, as the unrecognized-parameter error already does. This follows the rule from #5 that displaying connection options must never reveal a secret (
ConnectionParamsshowspassword=***). The value is dropped for every key rather than onlysslpassword, so no list of secret keys has to be kept in sync. Which values are accepted or rejected is unchanged. No public API or runtime dependency changes; only the error text differs.Malformed URIs can still echo credentials through URIs.jl's
ParseError, and a mistyped scheme can reach the keyword parser's "missing '='" error. Both have a different cause and are left for a separate issue.Validation:
srcchange reverted, the two "passphrase not in message" checks fail.Pkg.test(): 5347 checks pass on Julia 1.12.7 and 5321 on Julia 1.10.12 (Linux x64).🤖 Generated with Claude Code