Repository navigation
Ask the window which button was pressed, not Compose - #1060
Open
JingMatrix wants to merge 1 commit into
Open
JingMatrix wants to merge 1 commit into
JingMatrix wants to merge 1 commit into
Conversation
JingMatrix
force-pushed
the
fix-secondary-click-1055
branch
2 times, most recently
from
November 5, 2026 16:29
6ba37b9 to
5b73fda
Compare
A right click on a module row opened its scope instead of its menu again. material3's version also decides compose-ui's: Gradle takes whichever minimum is higher, material3's or the BOM's. alpha29 chose compose-ui 1.13.0-alpha01, which rewrote trackpad handling and stopped telling a row which button a pointer pressed. rc01 chooses 1.12.0, so the BOM's 1.12.1 governs again. The gesture no longer depends on that. A decorator on the window's callback reads the button from the MotionEvent and forwards every event untouched. A click made with the secondary button opens the menu. Dependencies updated throughout. Fixes #1055
JingMatrix
force-pushed
the
fix-secondary-click-1055
branch
from
November 5, 2026 16:31
5b73fda to
d1d43f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A right click on a module row opens its scope instead of its menu (#1055). #930 fixed that gesture in August and it worked then.
The material3 pin also decides compose-ui's version: Gradle takes whichever minimum is higher, material3's or the BOM's. alpha29 chose compose-ui 1.13.0-alpha01, which rewrote trackpad handling, and a row stopped being told which button was pressed, so a right click arrived looking like an ordinary tap. rc01 chooses 1.12.0, leaving the BOM's 1.12.1 to govern again, the version the gesture last worked on.
The gesture no longer asks Compose for the button either. A decorator on the window's callback reads it from the MotionEvent and forwards every event untouched, and a click made with that button opens the menu. Which row the pointer is over is still Compose's answer.
Dependencies are updated throughout and both manager modules compile. Untested on a touchpad; that needs the reporter.