Repository navigation
Isolate startup-failure test from installed Harnesses - #656
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the startup-failure test from reaching an installed Harness when PATH lookup skips its non-executable fixture
opencode.Add a regression test with a recording
opencodeon the inherited PATH. Other session-execution fixtures keep their inherited tools.Closes #652
Evidence
cargo test startup_failure_never_reaches_an_installed_harness -- --nocapturefailed in 0.14s:installed Harness ran.After: the regression passes; its recording executable never runs. The existing test still verifies
could not run opencode,ErrorKind::PermissionDenied, no completion reporting and nocallsfile.cargo test --bin thirdshift session::execution_tests -- --nocapture: all 10 tests passed. The independent Spec reviewer also ran all 10 successfully.cargo clippy --all-targets -- -D warnings: passed.cargo fmt --check: passed.SYSTEMD_UNIT_PATH=/usr/lib/systemd/system cargo test: full suite passed.The initial plain
cargo testrun stopped atsite_deploy::the_systemd_units_verify: systemd reported an invalidRequiredBykey in this host's unrelated/etc/systemd/system/career-dashboard-secrets.service. That test passes withSYSTEMD_UNIT_PATH=/usr/lib/systemd/system, using the packaged system units alongside the explicitly supplied repository units.Seams under test: the isolated session-execution test process, including its PATH lookup, spawn error and completion reporting.
Unaddressed findings
Both review axes read every changed file. Changed files left unread: none.
Merge Danger
Door: two-way
Blast Radius: tests
Only session-execution tests change; rollback is a normal revert.
Built with codex · gpt-6.1-sol · high