Repository navigation
Preserve literal arguments in Base fix and Security guidance - #649
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Base fix and Security fixing offers preserve literal arguments, including Model labels containing spaces. One Command line interface owns public flag reconstruction and POSIX shell rendering; omitted choices still consult the User config.
Closes #645
Evidence
cargo test --bin thirdshift args::tests::base_fix_guidance_preserves_a_model_label_with_spaces -- --exactfailed withunexpected argument after the Issue URL: Label.After: the same test passes through the production interface,
shargv recovery, and the public parser.cargo fmt --checkandcargo clippy --all-targets -- -D warningspass on the final commit.cargo teststopped atsite_deploy::the_systemd_units_verifybecause the host's unrelated/etc/systemd/system/career-dashboard-secrets.servicecontainsRequiredByin[Unit]. That exact test passes withSYSTEMD_UNIT_PATH=/usr/lib/systemd/system:/lib/systemd/system, which still validates this repo's units against vendor dependencies while excluding host overrides. Full suite passed withSYSTEMD_UNIT_PATH=/usr/lib/systemd/system:/lib/systemd/system cargo test(one existing unit test ignored).Test seams
Review
Standards and Spec reviewed against
mainat02b3365108f95e03df30f637647257b501cceed3, including the follow-up changes. Standards S1 (private rendering choices in caller assertions) and S2 (duplicated shell recovery helpers) are addressed. Spec reported no findings.Review coverage: both axes read all eight changed files, including supporting files. Changed files left unread: none.
Unaddressed findings
Merge Danger
Door: two-way
Reversible internal consolidation; command targets and permission policy remain the same.
Blast Radius: guidance
Both existing permission offers share the serializer; explicit public choices and omitted defaults are covered by shell/parser tests.
Built with codex · gpt-6.1-sol · high