Conversation
Signed-off-by: minleejae <mmj9808@gmail.com>
minleejae
marked this pull request as ready for review
September 28, 2026 09:18
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatementDeParserdrops the CTE from a top-levelWITH ... VALUESquery. For example,WITH cte(foo) AS (VALUES (42)) VALUES ((SELECT foo FROM cte))currently renders asVALUES ((SELECT foo FROM cte)), leaving an undefined relation. The original query was executed successfully on PostgreSQL 18.6 during corpus validation.Reuse the existing WITH-item deparser support for VALUES, preserving the configured select/expression visitors and their context. Keep the existing constructor and add a select-deparser/context path for callers. When VALUES is nested in an expression, let its deparser own the WITH clause so it is emitted exactly once.
Tests cover direct and statement deparsing, multiple/recursive/materialized CTEs, a data-modifying CTE, nested VALUES queries, custom visitor rewriting, callback context, and an unchanged source AST. No grammar changes are required.
Validation: all production sources compiled with Java 17, and all 32 tests passed across
ValuesWithDeParserTest,ValuesTest, andDmlSourceExpressionTestusing the offline JUnit runner. Manual round trips for the original/nested query forms also passed. Full Gradle/Maven checks remain for CI. Executing the patched output against PostgreSQL has not been repeated because local DB access is blocked.